Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2016-01-07 Thread Boris Brezillon
Hi Brian, On Wed, 6 Jan 2016 15:13:23 -0800 Brian Norris wrote: > On Sat, Dec 19, 2015 at 04:01:24AM +0100, Boris Brezillon wrote: > > Actually the nand_{get,set}_controller_data() helpers are not about > > assigning NAND controller private data (as you pointed those can > > already be retrieved

Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2016-01-06 Thread Brian Norris
On Sat, Dec 19, 2015 at 04:01:24AM +0100, Boris Brezillon wrote: > Actually the nand_{get,set}_controller_data() helpers are not about > assigning NAND controller private data (as you pointed those can > already be retrieved thanks to the ->controller field using the > container_of() trick), but pe

Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2015-12-18 Thread Boris Brezillon
Hi Brian, On Fri, 18 Dec 2015 14:17:58 -0800 Brian Norris wrote: > Hi Boris, > > On Thu, Dec 10, 2015 at 09:00:39AM +0100, Boris Brezillon wrote: > > Add two helpers to access the field reserved for private controller data. > > This makes it clearer what this field is reserved for and ease futu

Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2015-12-18 Thread Brian Norris
Hi Boris, On Thu, Dec 10, 2015 at 09:00:39AM +0100, Boris Brezillon wrote: > Add two helpers to access the field reserved for private controller data. > This makes it clearer what this field is reserved for and ease future > refactoring. I agree with the refactoring part, but I'm not sure about t

[PATCH v4 55/58] mtd: nand: add helpers to access ->priv

2015-12-10 Thread Boris Brezillon
Add two helpers to access the field reserved for private controller data. This makes it clearer what this field is reserved for and ease future refactoring. Signed-off-by: Boris Brezillon --- include/linux/mtd/nand.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/m