Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-29 Thread Stefano Brivio
On Fri, 28 Dec 2007 19:58:32 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote: > > Also, Christoph has recently posted a suggestion for how to improve > > the interface to allow the 'get' operation to return an error: > >

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-29 Thread Stefano Brivio
On Fri, 28 Dec 2007 19:58:32 +0100 Christoph Hellwig [EMAIL PROTECTED] wrote: On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote: Also, Christoph has recently posted a suggestion for how to improve the interface to allow the 'get' operation to return an error:

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-28 Thread Johannes Berg
On Fri, 2007-12-28 at 19:58 +0100, Christoph Hellwig wrote: > On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote: > > Also, Christoph has recently posted a suggestion for how to improve > > the interface to allow the 'get' operation to return an error: > >

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-28 Thread Christoph Hellwig
On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote: > Also, Christoph has recently posted a suggestion for how to improve > the interface to allow the 'get' operation to return an error: > http://patchwork.ozlabs.org/cbe-oss-dev/patch?id=14962 > > I'd suggest consolidating the two

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-28 Thread Christoph Hellwig
On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote: Also, Christoph has recently posted a suggestion for how to improve the interface to allow the 'get' operation to return an error: http://patchwork.ozlabs.org/cbe-oss-dev/patch?id=14962 I'd suggest consolidating the two changes

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-28 Thread Johannes Berg
On Fri, 2007-12-28 at 19:58 +0100, Christoph Hellwig wrote: On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote: Also, Christoph has recently posted a suggestion for how to improve the interface to allow the 'get' operation to return an error:

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-20 Thread Arnd Bergmann
On Thursday 20 December 2007, Stefano Brivio wrote: > debugfs: allow access to signed values > > Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to > remove > a cast in libfs, change the simple_attr_open prototype and thus fix the users > as > well. > > Cc: Johannes Berg

[PATCH v4 7/8] debugfs: allow access to signed values

2007-12-20 Thread Stefano Brivio
debugfs: allow access to signed values Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs, change the simple_attr_open prototype and thus fix the users as well. Cc: Johannes Berg <[EMAIL PROTECTED]> Cc: Mattias Nissler <[EMAIL PROTECTED]> To: Greg

[PATCH v4 7/8] debugfs: allow access to signed values

2007-12-20 Thread Stefano Brivio
debugfs: allow access to signed values Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs, change the simple_attr_open prototype and thus fix the users as well. Cc: Johannes Berg [EMAIL PROTECTED] Cc: Mattias Nissler [EMAIL PROTECTED] To: Greg

Re: [PATCH v4 7/8] debugfs: allow access to signed values

2007-12-20 Thread Arnd Bergmann
On Thursday 20 December 2007, Stefano Brivio wrote: debugfs: allow access to signed values Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs, change the simple_attr_open prototype and thus fix the users as well. Cc: Johannes Berg [EMAIL

[PATCH v4 7/8] debugfs: allow access to signed values

2007-12-19 Thread Stefano Brivio
Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs. Cc: Johannes Berg <[EMAIL PROTECTED]> Signed-off-by: Stefano Brivio <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- fs/debugfs/file.c | 166

[PATCH v4 7/8] debugfs: allow access to signed values

2007-12-19 Thread Stefano Brivio
Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove a cast in libfs. Cc: Johannes Berg [EMAIL PROTECTED] Signed-off-by: Stefano Brivio [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- fs/debugfs/file.c | 166