Re: [PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-30 Thread Daniel Santos
On 10/30/2012 08:02 PM, Josh Triplett wrote: > On Tue, Oct 30, 2012 at 08:19:05PM +0100, Borislav Petkov wrote: >> On Sun, Oct 28, 2012 at 03:57:15PM -0500, danielfsan...@att.net wrote: >>> Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just >>> call BUILD_BUG_ON_MSG. This not

Re: [PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-30 Thread Josh Triplett
On Tue, Oct 30, 2012 at 08:19:05PM +0100, Borislav Petkov wrote: > On Sun, Oct 28, 2012 at 03:57:15PM -0500, danielfsan...@att.net wrote: > > Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just > > call BUILD_BUG_ON_MSG. This not only reduces source code bloat, but > > also

Re: [PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-30 Thread Borislav Petkov
On Sun, Oct 28, 2012 at 03:57:15PM -0500, danielfsan...@att.net wrote: > Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just > call BUILD_BUG_ON_MSG. This not only reduces source code bloat, but > also prevents the possibility of code being changed for one macro and > not for

Re: [PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-30 Thread Borislav Petkov
On Sun, Oct 28, 2012 at 03:57:15PM -0500, danielfsan...@att.net wrote: Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just call BUILD_BUG_ON_MSG. This not only reduces source code bloat, but also prevents the possibility of code being changed for one macro and not for the

Re: [PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-30 Thread Josh Triplett
On Tue, Oct 30, 2012 at 08:19:05PM +0100, Borislav Petkov wrote: On Sun, Oct 28, 2012 at 03:57:15PM -0500, danielfsan...@att.net wrote: Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just call BUILD_BUG_ON_MSG. This not only reduces source code bloat, but also prevents

Re: [PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-30 Thread Daniel Santos
On 10/30/2012 08:02 PM, Josh Triplett wrote: On Tue, Oct 30, 2012 at 08:19:05PM +0100, Borislav Petkov wrote: On Sun, Oct 28, 2012 at 03:57:15PM -0500, danielfsan...@att.net wrote: Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just call BUILD_BUG_ON_MSG. This not only

[PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-28 Thread danielfsantos
Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just call BUILD_BUG_ON_MSG. This not only reduces source code bloat, but also prevents the possibility of code being changed for one macro and not for the other (which was previously the case for BUILD_BUG and BUILD_BUG_ON).

[PATCH v4 9/9] bug.h: Convert BUILD_BUG{,_ON} to use BUILD_BUG_ON_MSG

2012-10-28 Thread danielfsantos
Remove duplicate code by converting BUILD_BUG and BUILD_BUG_ON to just call BUILD_BUG_ON_MSG. This not only reduces source code bloat, but also prevents the possibility of code being changed for one macro and not for the other (which was previously the case for BUILD_BUG and BUILD_BUG_ON).