> On Feb 23, 2021, at 3:06 AM, Peter Zijlstra wrote:
>
> On Mon, Feb 22, 2021 at 05:20:10PM -0800, Song Liu wrote:
>> BPF helpers bpf_task_storage_[get|delete] could hold two locks:
>> bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling
>> these helpers from fentry/fexit
On 2/22/21 11:19 PM, Andrii Nakryiko wrote:
+ bpf_task_storage_lock();
sdata = bpf_local_storage_update(
task, (struct bpf_local_storage_map *)map, value, map_flags);
this should probably be container_of() instead of casting
bpf_task_storage.c uses casting in
On Mon, Feb 22, 2021 at 05:20:10PM -0800, Song Liu wrote:
> BPF helpers bpf_task_storage_[get|delete] could hold two locks:
> bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling
> these helpers from fentry/fexit programs on functions in bpf_*_storage.c
> may cause deadlock on
On Mon, Feb 22, 2021 at 11:16 PM Song Liu wrote:
>
>
>
> > On Feb 22, 2021, at 10:21 PM, Andrii Nakryiko
> > wrote:
> >
> > On Mon, Feb 22, 2021 at 5:23 PM Song Liu wrote:
> >>
> >> BPF helpers bpf_task_storage_[get|delete] could hold two locks:
> >> bpf_local_storage_map_bucket->lock and
> On Feb 22, 2021, at 10:21 PM, Andrii Nakryiko
> wrote:
>
> On Mon, Feb 22, 2021 at 5:23 PM Song Liu wrote:
>>
>> BPF helpers bpf_task_storage_[get|delete] could hold two locks:
>> bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling
>> these helpers from fentry/fexit
On Mon, Feb 22, 2021 at 5:23 PM Song Liu wrote:
>
> BPF helpers bpf_task_storage_[get|delete] could hold two locks:
> bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling
> these helpers from fentry/fexit programs on functions in bpf_*_storage.c
> may cause deadlock on either
BPF helpers bpf_task_storage_[get|delete] could hold two locks:
bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling
these helpers from fentry/fexit programs on functions in bpf_*_storage.c
may cause deadlock on either locks.
Prevent such deadlock with a per cpu counter,
7 matches
Mail list logo