Re: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread Russell King - ARM Linux admin
On Wed, Jan 27, 2021 at 02:37:34PM +, Stefan Chulski wrote: > Your mcbin-ss is A8K AX or A8K B0? On AX revisions we do not have FC support > in firmware. How do I tell? I don't want to remove the heatsink, and I don't see anything in MV-S88-00E. I didn't grab a copy of the Errata before

RE: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread Stefan Chulski
> > You can devmem 0xF2400240(Device ID Status Register). > > #define A8040_B0_DEVICE_ID 0x8045 > > #define A8040_AX_DEVICE_ID 0x8040 > > #define A7040_B0_DEVICE_ID 0x7045 > > #define A7040_AX_DEVICE_ID 0x7040 > > #define A3900_A1_DEVICE_ID 0x6025 > > #define

Re: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread Russell King - ARM Linux admin
On Wed, Jan 27, 2021 at 03:10:11PM +, Stefan Chulski wrote: > You can devmem 0xF2400240(Device ID Status Register). > #define A8040_B0_DEVICE_ID 0x8045 > #define A8040_AX_DEVICE_ID 0x8040 > #define A7040_B0_DEVICE_ID 0x7045 > #define A7040_AX_DEVICE_ID 0x7040 > #define

RE: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread Stefan Chulski
@vger.kernel.org; > k...@kernel.org; m...@semihalf.com; and...@lunn.ch; > aten...@kernel.org > Subject: Re: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC > firmware check > > On Wed, Jan 27, 2021 at 02:37:34PM +, Stefan Chulski wrote: > > Your mcbin-ss is A8K AX or A8K B0

RE: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread Stefan Chulski
rg; > k...@kernel.org; m...@semihalf.com; and...@lunn.ch; > aten...@kernel.org > Subject: [EXT] Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC > firmware check > > External Email > > -- >

Re: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread Russell King - ARM Linux admin
On Wed, Jan 27, 2021 at 01:43:35PM +0200, stef...@marvell.com wrote: > if (priv->global_tx_fc && priv->hw_version != MVPP21) { > - val = mvpp2_cm3_read(priv, MSS_FC_COM_REG); > - val |= FLOW_CONTROL_ENABLE_BIT; > - mvpp2_cm3_write(priv, MSS_FC_COM_REG,

[PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check

2021-01-27 Thread stefanc
From: Stefan Chulski Patch check that TX FC firmware is running in CM3. If not, global TX FC would be disabled. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 41 2 files changed,