Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-08-02 Thread David Miller
From: Alexei Starovoitov Date: Fri, 1 Aug 2014 12:12:36 -0700 > Dave, this patch has trivial conflict with Daniel's > ("team: fix releasing uninitialized pointer to BPF prog") fix. > Let me know if you want me to respin the series or you'll patch up > the conflict yourself. I took care of this,

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-08-01 Thread Alexei Starovoitov
On Fri, Aug 1, 2014 at 12:03 PM, Pablo Neira Ayuso wrote: >> > I think you can allocate the sk_filter once you get the final bpf >> > program, then you can memcpy() it. This adds some extra overhead in >> > the sk_attach_filter(), but that path is executed from user context >> > and it's also a ra

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-08-01 Thread Pablo Neira Ayuso
On Fri, Aug 01, 2014 at 09:50:31AM -0700, Alexei Starovoitov wrote: > On Fri, Aug 1, 2014 at 9:06 AM, Pablo Neira Ayuso wrote: > > On Thu, Jul 31, 2014 at 02:02:19PM -0700, Alexei Starovoitov wrote: > >> On Thu, Jul 31, 2014 at 12:40 PM, Pablo Neira Ayuso > >> wrote: > >> > On Wed, Jul 30, 2014

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-08-01 Thread Alexei Starovoitov
On Fri, Aug 1, 2014 at 9:06 AM, Pablo Neira Ayuso wrote: > On Thu, Jul 31, 2014 at 02:02:19PM -0700, Alexei Starovoitov wrote: >> On Thu, Jul 31, 2014 at 12:40 PM, Pablo Neira Ayuso >> wrote: >> > On Wed, Jul 30, 2014 at 08:34:16PM -0700, Alexei Starovoitov wrote: >> >> clean up names related to

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-08-01 Thread Pablo Neira Ayuso
On Thu, Jul 31, 2014 at 02:02:19PM -0700, Alexei Starovoitov wrote: > On Thu, Jul 31, 2014 at 12:40 PM, Pablo Neira Ayuso > wrote: > > On Wed, Jul 30, 2014 at 08:34:16PM -0700, Alexei Starovoitov wrote: > >> clean up names related to socket filtering and bpf in the following way: > >> - everythin

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-07-31 Thread Alexei Starovoitov
On Thu, Jul 31, 2014 at 12:40 PM, Pablo Neira Ayuso wrote: > On Wed, Jul 30, 2014 at 08:34:16PM -0700, Alexei Starovoitov wrote: >> clean up names related to socket filtering and bpf in the following way: >> - everything that deals with sockets keeps 'sk_*' prefix >> - everything that is pure BPF

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-07-31 Thread Pablo Neira Ayuso
On Wed, Jul 30, 2014 at 08:34:16PM -0700, Alexei Starovoitov wrote: > clean up names related to socket filtering and bpf in the following way: > - everything that deals with sockets keeps 'sk_*' prefix > - everything that is pure BPF is changed to 'bpf_*' prefix > > split 'struct sk_filter' into >

[PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-07-30 Thread Alexei Starovoitov
clean up names related to socket filtering and bpf in the following way: - everything that deals with sockets keeps 'sk_*' prefix - everything that is pure BPF is changed to 'bpf_*' prefix split 'struct sk_filter' into struct sk_filter { atomic_trefcnt; struct rcu_head rcu;