Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Wed, Jun 15, 2016 at 07:44:32AM -0500, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: > > There's no point in standard property names if the interpretation has to > > be non-standard. > Okay, I agree with the system specific interpretation part.

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Wed, Jun 15, 2016 at 07:44:32AM -0500, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: > > There's no point in standard property names if the interpretation has to > > be non-standard. > Okay, I agree with the system specific interpretation part. However, I > don't

RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On 16 June 2016 02:15, Xing Zheng wrote: > >> + /* Enable Headset and 4 Buttons Jack detection */ > >> + ret = snd_soc_card_jack_new(rtd->card, "Headset Jack", > >> + SND_JACK_HEADSET | > > Should this also include SND_JACK_LINEOUT? da7219

RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On 16 June 2016 02:15, Xing Zheng wrote: > >> + /* Enable Headset and 4 Buttons Jack detection */ > >> + ret = snd_soc_card_jack_new(rtd->card, "Headset Jack", > >> + SND_JACK_HEADSET | > > Should this also include SND_JACK_LINEOUT? da7219

Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Wed, Jun 15, 2016 at 5:44 AM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: >> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: >> >>> > +sound { >>> > +

Re: [alsa-devel] [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Wed, Jun 15, 2016 at 5:44 AM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: >> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: >> >>> > +sound { >>> > + compatible =

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

// + Adam, On 2016年06月16日 03:43, Steve Barber wrote: On Mon, Jun 13, 2016 at 1:42 AM, Xing Zheng wrote: + +static int rockchip_sound_da7219_hw_params(struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) +{ + struct

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

// + Adam, On 2016年06月16日 03:43, Steve Barber wrote: On Mon, Jun 13, 2016 at 1:42 AM, Xing Zheng wrote: + +static int rockchip_sound_da7219_hw_params(struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) +{ + struct snd_soc_pcm_runtime *rtd

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Mon, Jun 13, 2016 at 1:42 AM, Xing Zheng wrote: > Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) > on the RK3399 GRU boards, this patch can help us to support these codecs. > > Signed-off-by: Xing Zheng > --- > >

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Mon, Jun 13, 2016 at 1:42 AM, Xing Zheng wrote: > Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) > on the RK3399 GRU boards, this patch can help us to support these codecs. > > Signed-off-by: Xing Zheng > --- > > Changes in v5: > - fix the build warning for missing

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: > On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > >> > +sound { >> > + compatible = "rockchip,rk3399-gru-sound"; >> > + rockchip,cpu = <>; >> >

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown wrote: > On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: >> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > >> > +sound { >> > + compatible = "rockchip,rk3399-gru-sound"; >> > + rockchip,cpu = <>; >> > + rockchip,codec =

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: > On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > > +sound { > > + compatible = "rockchip,rk3399-gru-sound"; > > + rockchip,cpu = <>; > > + rockchip,codec = < >; > These seem fairly standard though a variety of

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: > On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > > +sound { > > + compatible = "rockchip,rk3399-gru-sound"; > > + rockchip,cpu = <>; > > + rockchip,codec = < >; > These seem fairly standard though a variety of

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) > on the RK3399 GRU boards, this patch can help us to support these codecs. > > Signed-off-by: Xing Zheng > --- > > Changes in v5: > -

Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) > on the RK3399 GRU boards, this patch can help us to support these codecs. > > Signed-off-by: Xing Zheng > --- > > Changes in v5: > - fix the build warning for

[PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) on the RK3399 GRU boards, this patch can help us to support these codecs. Signed-off-by: Xing Zheng --- Changes in v5: - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency Changes in

[PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) on the RK3399 GRU boards, this patch can help us to support these codecs. Signed-off-by: Xing Zheng --- Changes in v5: - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency Changes in v4: - the compatible name