Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-26 Thread Christoph Hellwig
On Tue, May 26, 2020 at 10:28:03AM -0400, Dan Schatzberg wrote: > Will do - I'll split out the lock-use refactor into a separate > patch. Do you have particular concerns about re-using the existing > spinlock? Its existing use is not contended so I didn't see any harm > in extending its use. I'll a

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-26 Thread Dan Schatzberg
On Tue, May 12, 2020 at 06:35:45AM -0700, Christoph Hellwig wrote: > On Tue, May 12, 2020 at 09:25:21AM -0400, Dan Schatzberg wrote: > > Seems like discussion on this patch series has died down. There's been > > a concern raised that we could generalize infrastructure across loop, > > md, etc. This

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-12 Thread Christoph Hellwig
On Tue, May 12, 2020 at 09:25:21AM -0400, Dan Schatzberg wrote: > Seems like discussion on this patch series has died down. There's been > a concern raised that we could generalize infrastructure across loop, > md, etc. This may be possible, in the future, but it isn't clear to me > how this would

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-12 Thread Dan Schatzberg
Seems like discussion on this patch series has died down. There's been a concern raised that we could generalize infrastructure across loop, md, etc. This may be possible, in the future, but it isn't clear to me how this would look like. I'm inclined to fix the existing issue with loop devices now

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-05 Thread Tejun Heo
Hello, Dave. On Tue, May 05, 2020 at 04:41:14PM +1000, Dave Chinner wrote: > > OTOH I don't have a great idea how the generic infrastructure should look > > like... > > I haven't given it any thought - it's not something I have any > bandwidth to spend time on. I'll happily review a unified > ge

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-05 Thread Johannes Weiner
On Tue, May 05, 2020 at 04:29:46PM +1000, Dave Chinner wrote: > On Tue, Apr 28, 2020 at 10:27:32PM -0400, Johannes Weiner wrote: > > On Wed, Apr 29, 2020 at 07:47:34AM +1000, Dave Chinner wrote: > > > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > > > This patch series does som

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-05 Thread Shakeel Butt
On Mon, May 4, 2020 at 11:30 PM Dave Chinner wrote: > > On Tue, Apr 28, 2020 at 10:27:32PM -0400, Johannes Weiner wrote: > > On Wed, Apr 29, 2020 at 07:47:34AM +1000, Dave Chinner wrote: > > > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > > > This patch series does some > > >

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-04 Thread Dave Chinner
On Wed, Apr 29, 2020 at 12:25:40PM +0200, Jan Kara wrote: > On Wed 29-04-20 07:47:34, Dave Chinner wrote: > > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > > The loop device runs all i/o to the backing file on a separate kworker > > > thread which results in all i/o being char

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-04 Thread Dave Chinner
On Tue, Apr 28, 2020 at 10:27:32PM -0400, Johannes Weiner wrote: > On Wed, Apr 29, 2020 at 07:47:34AM +1000, Dave Chinner wrote: > > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > > This patch series does some > > > minor modification to the loop driver so that each cgroup can

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-29 Thread Jan Kara
On Wed 29-04-20 10:22:30, Tejun Heo wrote: > Hello, > > On Wed, Apr 29, 2020 at 12:25:40PM +0200, Jan Kara wrote: > > Yeah, I was thinking about the same when reading the patch series > > description. We already have some cgroup workarounds for btrfs kthreads if > > I remember correctly, we have c

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-29 Thread Tejun Heo
Hello, On Wed, Apr 29, 2020 at 12:25:40PM +0200, Jan Kara wrote: > Yeah, I was thinking about the same when reading the patch series > description. We already have some cgroup workarounds for btrfs kthreads if > I remember correctly, we have cgroup handling for flush workers, now we are > adding c

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-29 Thread Dan Schatzberg
On Wed, Apr 29, 2020 at 07:47:34AM +1000, Dave Chinner wrote: > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > The loop device runs all i/o to the backing file on a separate kworker > > thread which results in all i/o being charged to the root cgroup. This > > allows a loop dev

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-29 Thread Jan Kara
On Wed 29-04-20 07:47:34, Dave Chinner wrote: > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > The loop device runs all i/o to the backing file on a separate kworker > > thread which results in all i/o being charged to the root cgroup. This > > allows a loop device to be used t

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-28 Thread Johannes Weiner
On Wed, Apr 29, 2020 at 07:47:34AM +1000, Dave Chinner wrote: > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > This patch series does some > > minor modification to the loop driver so that each cgroup can make > > forward progress independently to avoid this inversion. > > > >

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-28 Thread Dave Chinner
On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > The loop device runs all i/o to the backing file on a separate kworker > thread which results in all i/o being charged to the root cgroup. This > allows a loop device to be used to trivially bypass resource limits > and other policy.

[PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-04-28 Thread Dan Schatzberg
Changes since V5: * Fixed a missing css_put when failing to allocate a worker * Minor style changes Changes since V4: Only patches 1 and 2 have changed. * Fixed irq lock ordering bug * Simplified loop detach * Added support for nesting memalloc_use_memcg Changes since V3: * Fix race on loop d