Re: [PATCH v5 02/12] KVM: hide KVM_MEMSLOT_INVALID from userspace

2012-08-09 Thread Xiao Guangrong
On 08/10/2012 02:48 AM, Marcelo Tosatti wrote: >> +#define KVM_MEMSLOT_INVALID (1UL << 31) >> + >> /* >> * If we support unaligned MMIO, at most one fragment will be split into >> two: >> */ > > Please document which range is for userspace visible flags, which range > is reserved. Mention t

Re: [PATCH v5 02/12] KVM: hide KVM_MEMSLOT_INVALID from userspace

2012-08-09 Thread Marcelo Tosatti
On Tue, Aug 07, 2012 at 05:48:49PM +0800, Xiao Guangrong wrote: > Quote Avi's comment: > | KVM_MEMSLOT_INVALID is actually an internal symbol, not used by > | userspace. Please move it to kvm_host.h. > > Also, move KVM_MEMSLOT_INVALID to the highest bit > > Signed-off-by: Xiao Guangrong > --- >

[PATCH v5 02/12] KVM: hide KVM_MEMSLOT_INVALID from userspace

2012-08-07 Thread Xiao Guangrong
Quote Avi's comment: | KVM_MEMSLOT_INVALID is actually an internal symbol, not used by | userspace. Please move it to kvm_host.h. Also, move KVM_MEMSLOT_INVALID to the highest bit Signed-off-by: Xiao Guangrong --- include/linux/kvm.h |1 - include/linux/kvm_host.h |2 ++ 2 files c