Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-28 Thread Kever Yang
Hi Doug, On 01/28/2016 03:44 AM, Doug Anderson wrote: If it's all the same to you, I'll probably change it back to 525 and then increase the periodic FIFO size by 3 DWORDS in the next patch. 12 bytes may not be much, but might as well make use of them to improve performance / compatibility?

Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-28 Thread Kever Yang
Hi Doug, On 01/28/2016 03:44 AM, Doug Anderson wrote: If it's all the same to you, I'll probably change it back to 525 and then increase the periodic FIFO size by 3 DWORDS in the next patch. 12 bytes may not be much, but might as well make use of them to improve performance / compatibility?

Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-27 Thread Doug Anderson
Kever, On Wed, Jan 27, 2016 at 2:13 AM, Kever Yang wrote: > Hi Doug, > > On 01/23/2016 02:18 AM, Douglas Anderson wrote: >> >> As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should >> really be: >> 2 * ((Largest Packet size / 4) + 1 + 1) + n >> with n = number of host

Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-27 Thread Kever Yang
Hi Doug, On 01/23/2016 02:18 AM, Douglas Anderson wrote: As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should really be: 2 * ((Largest Packet size / 4) + 1 + 1) + n with n = number of host channel. We have 9 host channels, so 2 * ((1024/4) + 2) + 9 = 516 + 9 = 525

Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-27 Thread Doug Anderson
Kever, On Wed, Jan 27, 2016 at 2:13 AM, Kever Yang wrote: > Hi Doug, > > On 01/23/2016 02:18 AM, Douglas Anderson wrote: >> >> As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should >> really be: >> 2 * ((Largest Packet size / 4) + 1 + 1) + n >>

Re: [PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-27 Thread Kever Yang
Hi Doug, On 01/23/2016 02:18 AM, Douglas Anderson wrote: As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should really be: 2 * ((Largest Packet size / 4) + 1 + 1) + n with n = number of host channel. We have 9 host channels, so 2 * ((1024/4) + 2) + 9 = 516 + 9 = 525

[PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-22 Thread Douglas Anderson
As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should really be: 2 * ((Largest Packet size / 4) + 1 + 1) + n with n = number of host channel. We have 9 host channels, so 2 * ((1024/4) + 2) + 9 = 516 + 9 = 525 We've got 960 / 972 total_fifo_size on rk3288 (and presumably on

[PATCH v5 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066

2016-01-22 Thread Douglas Anderson
As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should really be: 2 * ((Largest Packet size / 4) + 1 + 1) + n with n = number of host channel. We have 9 host channels, so 2 * ((1024/4) + 2) + 9 = 516 + 9 = 525 We've got 960 / 972 total_fifo_size on rk3288 (and presumably on