Re: [PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S

2015-06-12 Thread Borislav Petkov
On Thu, Jun 11, 2015 at 02:14:39PM +0100, Matt Fleming wrote: > Yeah, fair enough. Though it's worth noting that because we're calling > firmware functions, which use the Microsoft ABI, %rbp will be saved by > the callee function if used. Yeah, just looked at the spec. But you know how we don't

Re: [PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S

2015-06-12 Thread Borislav Petkov
On Thu, Jun 11, 2015 at 02:14:39PM +0100, Matt Fleming wrote: Yeah, fair enough. Though it's worth noting that because we're calling firmware functions, which use the Microsoft ABI, %rbp will be saved by the callee function if used. Yeah, just looked at the spec. But you know how we don't

Re: [PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S

2015-06-11 Thread Matt Fleming
On Wed, 10 Jun, at 07:06:14AM, Josh Poimboeuf wrote: > Fix the following asmvalidate warnings: > >asmvalidate: arch/x86/platform/efi/efi_stub_64.o: efi_call(): missing > FP_SAVE/RESTORE macros >asmvalidate: arch/x86/boot/compressed/efi_stub_64.o: efi_call(): missing > FP_SAVE/RESTORE

Re: [PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S

2015-06-11 Thread Matt Fleming
On Wed, 10 Jun, at 07:06:14AM, Josh Poimboeuf wrote: Fix the following asmvalidate warnings: asmvalidate: arch/x86/platform/efi/efi_stub_64.o: efi_call(): missing FP_SAVE/RESTORE macros asmvalidate: arch/x86/boot/compressed/efi_stub_64.o: efi_call(): missing FP_SAVE/RESTORE macros

[PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S

2015-06-10 Thread Josh Poimboeuf
Fix the following asmvalidate warnings: asmvalidate: arch/x86/platform/efi/efi_stub_64.o: efi_call(): missing FP_SAVE/RESTORE macros asmvalidate: arch/x86/boot/compressed/efi_stub_64.o: efi_call(): missing FP_SAVE/RESTORE macros efi_call() is a non-leaf callable function, so save/restore

[PATCH v5 06/10] x86/asm/efi: Fix asmvalidate warnings for efi_stub_64.S

2015-06-10 Thread Josh Poimboeuf
Fix the following asmvalidate warnings: asmvalidate: arch/x86/platform/efi/efi_stub_64.o: efi_call(): missing FP_SAVE/RESTORE macros asmvalidate: arch/x86/boot/compressed/efi_stub_64.o: efi_call(): missing FP_SAVE/RESTORE macros efi_call() is a non-leaf callable function, so save/restore