Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-16 Thread Uwe Kleine-König
Hello Michael, On Wed, Jul 15, 2020 at 10:41:25PM +0200, Michael Walle wrote: > Am 2020-07-15 20:18, schrieb Uwe Kleine-König: > > On Wed, Jul 15, 2020 at 07:45:10PM +0200, Michael Walle wrote: > > > > > > Am 2020-07-15 18:36, schrieb Uwe Kleine-König: > > > > On Tue, Jul 14, 2020 at 11:09:28PM

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-15 Thread Michael Walle
Hi Uwe, Am 2020-07-15 20:18, schrieb Uwe Kleine-König: On Wed, Jul 15, 2020 at 07:45:10PM +0200, Michael Walle wrote: Am 2020-07-15 18:36, schrieb Uwe Kleine-König: > On Tue, Jul 14, 2020 at 11:09:28PM +0200, Michael Walle wrote: > > > My wishlist (just as it comes to my mind, so no guarantee

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-15 Thread Uwe Kleine-König
On Wed, Jul 15, 2020 at 07:45:10PM +0200, Michael Walle wrote: > Hi Uwe, > > Am 2020-07-15 18:36, schrieb Uwe Kleine-König: > > On Tue, Jul 14, 2020 at 11:09:28PM +0200, Michael Walle wrote: > > > > My wishlist (just as it comes to my mind, so no guarantee of > > > > completeness): > > > > > > >

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-15 Thread Michael Walle
Hi Uwe, Am 2020-07-15 18:36, schrieb Uwe Kleine-König: On Tue, Jul 14, 2020 at 11:09:28PM +0200, Michael Walle wrote: > My wishlist (just as it comes to my mind, so no guarantee of > completeness): > > - can do 0% duty cycle for all supported period lengths > - can do 100% duty cycle for all

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-15 Thread Uwe Kleine-König
Hello Michael, On Tue, Jul 14, 2020 at 11:09:28PM +0200, Michael Walle wrote: > > My wishlist (just as it comes to my mind, so no guarantee of > > completeness): > > > > - can do 0% duty cycle for all supported period lengths > > - can do 100% duty cycle for all supported period lengths > > -

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-14 Thread Michael Walle
Hi Uwe, Am 2020-07-14 18:08, schrieb Uwe Kleine-König: On Tue, Jul 14, 2020 at 01:31:13PM +0200, Michael Walle wrote: Am 2020-07-13 10:47, schrieb Uwe Kleine-König: > I already thought about proposing pwm_get_rate_hw(), but for now there > is (AFAICT) no user who would need it. And it's hard

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-14 Thread Uwe Kleine-König
Hello Michael, On Tue, Jul 14, 2020 at 01:31:13PM +0200, Michael Walle wrote: > Am 2020-07-13 10:47, schrieb Uwe Kleine-König: > > I already thought about proposing pwm_get_rate_hw(), but for now there > > is (AFAICT) no user who would need it. And it's hard to know which > > variant is actually

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-14 Thread Michael Walle
Hi Uwe, Am 2020-07-13 10:47, schrieb Uwe Kleine-König: On Sat, Jul 11, 2020 at 07:28:05PM +0200, Michael Walle wrote: Am 2020-07-09 10:50, schrieb Uwe Kleine-König: > On Mon, Jul 06, 2020 at 07:53:47PM +0200, Michael Walle wrote: > > diff --git a/drivers/pwm/pwm-sl28cpld.c

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-13 Thread Uwe Kleine-König
Hello Michael, On Sat, Jul 11, 2020 at 07:28:05PM +0200, Michael Walle wrote: > Am 2020-07-09 10:50, schrieb Uwe Kleine-König: > > On Mon, Jul 06, 2020 at 07:53:47PM +0200, Michael Walle wrote: > > > diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c > > > new file mode 100644 >

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-11 Thread Michael Walle
Hi Uwe, first of all, thank you for that thorough review. Am 2020-07-09 10:50, schrieb Uwe Kleine-König: On Mon, Jul 06, 2020 at 07:53:47PM +0200, Michael Walle wrote: diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c new file mode 100644 index ..8ee286b605bf

Re: [PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-09 Thread Uwe Kleine-König
Hello Michael, On Mon, Jul 06, 2020 at 07:53:47PM +0200, Michael Walle wrote: > diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c > new file mode 100644 > index ..8ee286b605bf > --- /dev/null > +++ b/drivers/pwm/pwm-sl28cpld.c > @@ -0,0 +1,187 @@ > +//

[PATCH v5 07/13] pwm: add support for sl28cpld PWM controller

2020-07-06 Thread Michael Walle
Add support for the PWM controller of the sl28cpld board management controller. This is part of a multi-function device driver. The controller has one PWM channel and can just generate four distinct frequencies. Signed-off-by: Michael Walle --- Changes since v4: - update copyright year -