Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Vincent Guittot
On 11 September 2014 12:13, Peter Zijlstra wrote: > On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 18db43e..60ae1ce 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -6049,6 +6049,14 @@

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > + if ((capacity_orig_of(src_cpu) * 100) > (capacity_of(src_cpu) * > + sd->imbalance_pct)) Note that capacity_orig_of() is introduced a lot later on in the series. Patch 10 iirc, so this will

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Vincent Guittot
On 11 September 2014 12:07, Peter Zijlstra wrote: > On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 18db43e..60ae1ce 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -6049,6 +6049,14 @@

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 18db43e..60ae1ce 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env *env, >

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 18db43e..60ae1ce 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env *env, >

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Wed, Sep 03, 2014 at 05:56:04PM +0530, Preeti U Murthy wrote: > On 09/03/2014 05:14 PM, Vincent Guittot wrote: > > On 3 September 2014 11:11, Preeti U Murthy > > wrote: > >> On 09/01/2014 02:15 PM, Vincent Guittot wrote: > >>> On 30 August 2014 19:50, Preeti U Murthy > >>> wrote: > Hi

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Wed, Sep 03, 2014 at 05:56:04PM +0530, Preeti U Murthy wrote: On 09/03/2014 05:14 PM, Vincent Guittot wrote: On 3 September 2014 11:11, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: On 09/01/2014 02:15 PM, Vincent Guittot wrote: On 30 August 2014 19:50, Preeti U Murthy

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env *env,

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env *env,

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Vincent Guittot
On 11 September 2014 12:07, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6049,6

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Peter Zijlstra
On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: + if ((capacity_orig_of(src_cpu) * 100) (capacity_of(src_cpu) * + sd-imbalance_pct)) Note that capacity_orig_of() is introduced a lot later on in the series. Patch 10 iirc, so this will not

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-11 Thread Vincent Guittot
On 11 September 2014 12:13, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 26, 2014 at 01:06:51PM +0200, Vincent Guittot wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6049,6

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-05 Thread Vincent Guittot
On 5 September 2014 14:06, Preeti U Murthy wrote: > Hi Vincent, > > On 08/26/2014 04:36 PM, Vincent Guittot wrote: >> If the CPU is used for handling lot of IRQs, trig a load balance to check if >> it's worth moving its tasks on another CPU that has more capacity. >> >> As a sidenote, this will

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-05 Thread Preeti U Murthy
Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: > If the CPU is used for handling lot of IRQs, trig a load balance to check if > it's worth moving its tasks on another CPU that has more capacity. > > As a sidenote, this will note generate more spurious ilb because we already > trig an

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-05 Thread Preeti U Murthy
Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: If the CPU is used for handling lot of IRQs, trig a load balance to check if it's worth moving its tasks on another CPU that has more capacity. As a sidenote, this will note generate more spurious ilb because we already trig an ilb

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-05 Thread Vincent Guittot
On 5 September 2014 14:06, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: If the CPU is used for handling lot of IRQs, trig a load balance to check if it's worth moving its tasks on another CPU that has more capacity. As a

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Vincent Guittot
On 3 September 2014 14:26, Preeti U Murthy wrote: > On 09/03/2014 05:14 PM, Vincent Guittot wrote: >> On 3 September 2014 11:11, Preeti U Murthy wrote: >>> On 09/01/2014 02:15 PM, Vincent Guittot wrote: [snip] >>> >>> Ok I understand your explanation above. But I was wondering if you would >>>

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Preeti U Murthy
On 09/03/2014 05:14 PM, Vincent Guittot wrote: > On 3 September 2014 11:11, Preeti U Murthy wrote: >> On 09/01/2014 02:15 PM, Vincent Guittot wrote: >>> On 30 August 2014 19:50, Preeti U Murthy wrote: Hi Vincent, > index 18db43e..60ae1ce 100644 > --- a/kernel/sched/fair.c > +++

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Vincent Guittot
On 3 September 2014 11:11, Preeti U Murthy wrote: > On 09/01/2014 02:15 PM, Vincent Guittot wrote: >> On 30 August 2014 19:50, Preeti U Murthy wrote: >>> Hi Vincent, index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6049,6 +6049,14 @@

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Preeti U Murthy
On 09/01/2014 02:15 PM, Vincent Guittot wrote: > On 30 August 2014 19:50, Preeti U Murthy wrote: >> Hi Vincent, >>> index 18db43e..60ae1ce 100644 >>> --- a/kernel/sched/fair.c >>> +++ b/kernel/sched/fair.c >>> @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env >>> *env, >>>

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Preeti U Murthy
On 09/01/2014 02:15 PM, Vincent Guittot wrote: On 30 August 2014 19:50, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Vincent, index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Vincent Guittot
On 3 September 2014 11:11, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: On 09/01/2014 02:15 PM, Vincent Guittot wrote: On 30 August 2014 19:50, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Vincent, index 18db43e..60ae1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Preeti U Murthy
On 09/03/2014 05:14 PM, Vincent Guittot wrote: On 3 September 2014 11:11, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: On 09/01/2014 02:15 PM, Vincent Guittot wrote: On 30 August 2014 19:50, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Vincent, index 18db43e..60ae1ce 100644 ---

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-03 Thread Vincent Guittot
On 3 September 2014 14:26, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: On 09/03/2014 05:14 PM, Vincent Guittot wrote: On 3 September 2014 11:11, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: On 09/01/2014 02:15 PM, Vincent Guittot wrote: [snip] Ok I understand your explanation

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-01 Thread Vincent Guittot
On 30 August 2014 19:50, Preeti U Murthy wrote: > Hi Vincent, > > On 08/26/2014 04:36 PM, Vincent Guittot wrote: >> If the CPU is used for handling lot of IRQs, trig a load balance to check if >> it's worth moving its tasks on another CPU that has more capacity. >> >> As a sidenote, this will

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-09-01 Thread Vincent Guittot
On 30 August 2014 19:50, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: If the CPU is used for handling lot of IRQs, trig a load balance to check if it's worth moving its tasks on another CPU that has more capacity. As a sidenote,

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-08-30 Thread Preeti U Murthy
Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: > If the CPU is used for handling lot of IRQs, trig a load balance to check if > it's worth moving its tasks on another CPU that has more capacity. > > As a sidenote, this will note generate more spurious ilb because we already > trig an

Re: [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-08-30 Thread Preeti U Murthy
Hi Vincent, On 08/26/2014 04:36 PM, Vincent Guittot wrote: If the CPU is used for handling lot of IRQs, trig a load balance to check if it's worth moving its tasks on another CPU that has more capacity. As a sidenote, this will note generate more spurious ilb because we already trig an ilb

[PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-08-26 Thread Vincent Guittot
If the CPU is used for handling lot of IRQs, trig a load balance to check if it's worth moving its tasks on another CPU that has more capacity. As a sidenote, this will note generate more spurious ilb because we already trig an ilb if there is more than 1 busy cpu. If this cpu is the only one

[PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity

2014-08-26 Thread Vincent Guittot
If the CPU is used for handling lot of IRQs, trig a load balance to check if it's worth moving its tasks on another CPU that has more capacity. As a sidenote, this will note generate more spurious ilb because we already trig an ilb if there is more than 1 busy cpu. If this cpu is the only one