Re: [PATCH v5 08/12] soc: mediatek: cmdq: define the instruction struct

Hi, Bibby: On Tue, 2019-05-07 at 16:13 +0800, Bibby Hsieh wrote: > Define a instruction structure for gce driver to append command. I would like you to describe _WHY_ do this. I think you do this for 'code readability'. > > Signed-off-by: Bibby Hsieh > --- >

[PATCH v5 08/12] soc: mediatek: cmdq: define the instruction struct

Define a instruction structure for gce driver to append command. Signed-off-by: Bibby Hsieh --- drivers/soc/mediatek/mtk-cmdq-helper.c | 113 +++ include/linux/mailbox/mtk-cmdq-mailbox.h | 2 + include/linux/soc/mediatek/mtk-cmdq.h| 14 +-- 3 files changed, 84