Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Robin, Thanks for your reply. On 02/28/2018 11:06 PM, Robin Murphy wrote: On 28/02/18 13:00, JeffyChen wrote: Hi Robin, Thanks for your reply. On 02/28/2018 12:59 AM, Robin Murphy wrote: the rockchip IOMMU is part of the master block in hardware, so it needs to control the master's

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Robin, Thanks for your reply. On 02/28/2018 11:06 PM, Robin Murphy wrote: On 28/02/18 13:00, JeffyChen wrote: Hi Robin, Thanks for your reply. On 02/28/2018 12:59 AM, Robin Murphy wrote: the rockchip IOMMU is part of the master block in hardware, so it needs to control the master's

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 28/02/18 13:00, JeffyChen wrote: Hi Robin, Thanks for your reply. On 02/28/2018 12:59 AM, Robin Murphy wrote: the rockchip IOMMU is part of the master block in hardware, so it needs to control the master's power domain and some of the master's clocks when access it's registers. and the

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 28/02/18 13:00, JeffyChen wrote: Hi Robin, Thanks for your reply. On 02/28/2018 12:59 AM, Robin Murphy wrote: the rockchip IOMMU is part of the master block in hardware, so it needs to control the master's power domain and some of the master's clocks when access it's registers. and the

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Robin, Thanks for your reply. On 02/28/2018 12:59 AM, Robin Murphy wrote: the rockchip IOMMU is part of the master block in hardware, so it needs to control the master's power domain and some of the master's clocks when access it's registers. and the number of clocks needed here, might be

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Robin, Thanks for your reply. On 02/28/2018 12:59 AM, Robin Murphy wrote: the rockchip IOMMU is part of the master block in hardware, so it needs to control the master's power domain and some of the master's clocks when access it's registers. and the number of clocks needed here, might be

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 23/02/18 10:24, JeffyChen wrote: Hi guys, On 02/01/2018 07:19 PM, JeffyChen wrote: diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt index 2098f7732264..33dd853359fa 100644 ---

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 23/02/18 10:24, JeffyChen wrote: Hi guys, On 02/01/2018 07:19 PM, JeffyChen wrote: diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt index 2098f7732264..33dd853359fa 100644 ---

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On Wed, Feb 14, 2018 at 7:03 PM, Vivek Gautam wrote: > > > On 1/24/2018 7:19 PM, Robin Murphy wrote: >> >> On 24/01/18 10:35, Jeffy Chen wrote: >>> >>> From: Tomasz Figa >>> >>> Current code relies on master driver enabling necessary clocks before

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On Wed, Feb 14, 2018 at 7:03 PM, Vivek Gautam wrote: > > > On 1/24/2018 7:19 PM, Robin Murphy wrote: >> >> On 24/01/18 10:35, Jeffy Chen wrote: >>> >>> From: Tomasz Figa >>> >>> Current code relies on master driver enabling necessary clocks before >>> IOMMU is accessed, however there are cases

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 1/24/2018 7:19 PM, Robin Murphy wrote: On 24/01/18 10:35, Jeffy Chen wrote: From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 1/24/2018 7:19 PM, Robin Murphy wrote: On 24/01/18 10:35, Jeffy Chen wrote: From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not running yet, for

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On Wed, Jan 31, 2018 at 1:52 AM, Tomasz Figa wrote: > Hi Rob, > > On Wed, Jan 31, 2018 at 2:05 AM, Rob Herring wrote: >> On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: >>> From: Tomasz Figa >>> >>> Current code relies on

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On Wed, Jan 31, 2018 at 1:52 AM, Tomasz Figa wrote: > Hi Rob, > > On Wed, Jan 31, 2018 at 2:05 AM, Rob Herring wrote: >> On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: >>> From: Tomasz Figa >>> >>> Current code relies on master driver enabling necessary clocks before >>> IOMMU is

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Rob, On Wed, Jan 31, 2018 at 2:05 AM, Rob Herring wrote: > On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: >> From: Tomasz Figa >> >> Current code relies on master driver enabling necessary clocks before >> IOMMU is accessed, however there are

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Rob, On Wed, Jan 31, 2018 at 2:05 AM, Rob Herring wrote: > On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: >> From: Tomasz Figa >> >> Current code relies on master driver enabling necessary clocks before >> IOMMU is accessed, however there are cases when the IOMMU should be >>

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: > From: Tomasz Figa > > Current code relies on master driver enabling necessary clocks before > IOMMU is accessed, however there are cases when the IOMMU should be > accessed while the master is not running yet, for

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: > From: Tomasz Figa > > Current code relies on master driver enabling necessary clocks before > IOMMU is accessed, however there are cases when the IOMMU should be > accessed while the master is not running yet, for example allocating >

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Robin, Thanks for your reply. On 01/24/2018 09:49 PM, Robin Murphy wrote: +Optional properties: +- clocks : A list of master clocks requires for the IOMMU to be accessible s/requires/required/ ok + by the host CPU. The number of clocks depends on the master +

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Hi Robin, Thanks for your reply. On 01/24/2018 09:49 PM, Robin Murphy wrote: +Optional properties: +- clocks : A list of master clocks requires for the IOMMU to be accessible s/requires/required/ ok + by the host CPU. The number of clocks depends on the master +

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 24/01/18 10:35, Jeffy Chen wrote: From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not running yet, for example allocating V4L2

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

On 24/01/18 10:35, Jeffy Chen wrote: From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not running yet, for example allocating V4L2 videobuf2 buffers, which is

[PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not running yet, for example allocating V4L2 videobuf2 buffers, which is done by the VB2

[PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not running yet, for example allocating V4L2 videobuf2 buffers, which is done by the VB2 framework using DMA