Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2017-01-02 Thread Hanjun Guo
On 01/01/2017 04:45 AM, Rafael J. Wysocki wrote: On Fri, Dec 30, 2016 at 11:50 AM, Hanjun Guo wrote: [...] So how about just add the code as below? Works for me. OK, will send out the updated patch set soon. diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 11e63dd..37a8dfe

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-31 Thread Rafael J. Wysocki
On Fri, Dec 30, 2016 at 11:50 AM, Hanjun Guo wrote: > Hi Rafael, > > On 2016/12/26 9:31, Hanjun Guo wrote: > [cut] >> >> + if (pdevinfo->pre_add_cb) >> + pdevinfo->pre_add_cb(&pdev->dev); >> + > -> because it looks like this might be done in acpi_platform_notify() > for

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-30 Thread Hanjun Guo
Hi Rafael, On 2016/12/26 9:31, Hanjun Guo wrote: [cut] > > + if (pdevinfo->pre_add_cb) > + pdevinfo->pre_add_cb(&pdev->dev); > + -> because it looks like this might be done in acpi_platform_notify() for platform devices. >>> It works and I just simply add the code bel

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-30 Thread Hanjun Guo
On 2016/12/29 22:44, Sinan Kaya wrote: > On 12/25/2016 8:31 PM, Hanjun Guo wrote: >>> A type->setup() would be somewhat cleaner I think, but then it's more >>> code. Whichever works better I guess. :-) >> Agree, I will demo the type->setup() way and send out the patch for review, >> also I find on

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-30 Thread Xinwei Kong
On 2016/12/22 13:35, Hanjun Guo wrote: From: Hanjun Guo With the platform msi domain created, we can set up the msi domain for a platform device when it's probed. In order to do that, we need to get the domain that the platform device connecting to, so the iort_get_platform_device_domain() is

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-29 Thread Sinan Kaya
On 12/25/2016 8:31 PM, Hanjun Guo wrote: >> A type->setup() would be somewhat cleaner I think, but then it's more >> code. Whichever works better I guess. :-) > Agree, I will demo the type->setup() way and send out the patch for review, > also I find one minor issue for the IORT code, will update

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-25 Thread Hanjun Guo
Hi Rafael, Happy holidays! reply inline. On 2016/12/26 8:31, Rafael J. Wysocki wrote: > On Sat, Dec 24, 2016 at 8:34 AM, Hanjun Guo wrote: >> Hi Rafael, >> >> Thank you for your comments, when I was demoing your suggestion, >> I got a little bit confusions, please see my comments below. >> > [cu

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-25 Thread Rafael J. Wysocki
On Sat, Dec 24, 2016 at 8:34 AM, Hanjun Guo wrote: > Hi Rafael, > > Thank you for your comments, when I was demoing your suggestion, > I got a little bit confusions, please see my comments below. > [cut] >>> + >>> +/** >>> * acpi_create_platform_device - Create platform device for ACPI device

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-23 Thread Hanjun Guo
Hi Rafael, Thank you for your comments, when I was demoing your suggestion, I got a little bit confusions, please see my comments below. On 2016/12/22 20:57, Rafael J. Wysocki wrote: > On Thu, Dec 22, 2016 at 6:35 AM, Hanjun Guo wrote: >> From: Hanjun Guo >> >> With the platform msi domain crea

Re: [PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-22 Thread Rafael J. Wysocki
On Thu, Dec 22, 2016 at 6:35 AM, Hanjun Guo wrote: > From: Hanjun Guo > > With the platform msi domain created, we can set up the msi domain > for a platform device when it's probed. > > In order to do that, we need to get the domain that the platform > device connecting to, so the iort_get_platf

[PATCH v5 09/14] ACPI: platform: setup MSI domain for ACPI based platform device

2016-12-21 Thread Hanjun Guo
From: Hanjun Guo With the platform msi domain created, we can set up the msi domain for a platform device when it's probed. In order to do that, we need to get the domain that the platform device connecting to, so the iort_get_platform_device_domain() is introduced to retrieve the domain from io