Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-30 Thread Baolin Wang
Hi Jacek, On 30 August 2018 at 11:26, Baolin Wang wrote: > Hi Jacek, > > On 30 August 2018 at 03:15, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 08/29/2018 11:48 AM, Baolin Wang wrote: >>> Hi Jacek, >>> >>> On 29 August 2018 at 04:25, Jacek Anaszewski >>> wrote: On 08/25/2018 09:51

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-30 Thread Baolin Wang
Hi Jacek, On 30 August 2018 at 11:26, Baolin Wang wrote: > Hi Jacek, > > On 30 August 2018 at 03:15, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 08/29/2018 11:48 AM, Baolin Wang wrote: >>> Hi Jacek, >>> >>> On 29 August 2018 at 04:25, Jacek Anaszewski >>> wrote: On 08/25/2018 09:51

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Baolin Wang
Hi Jacek, On 30 August 2018 at 03:15, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/29/2018 11:48 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 29 August 2018 at 04:25, Jacek Anaszewski >> wrote: >>> On 08/25/2018 09:51 AM, Baolin Wang wrote: On 25 August 2018 at 04:44, Jacek Anaszewski

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Baolin Wang
Hi Jacek, On 30 August 2018 at 03:15, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/29/2018 11:48 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 29 August 2018 at 04:25, Jacek Anaszewski >> wrote: >>> On 08/25/2018 09:51 AM, Baolin Wang wrote: On 25 August 2018 at 04:44, Jacek Anaszewski

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Jacek Anaszewski
Hi Baolin, On 08/29/2018 11:48 AM, Baolin Wang wrote: > Hi Jacek, > > On 29 August 2018 at 04:25, Jacek Anaszewski > wrote: >> On 08/25/2018 09:51 AM, Baolin Wang wrote: >>> On 25 August 2018 at 04:44, Jacek Anaszewski >>> wrote: On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Jacek Anaszewski
Hi Baolin, On 08/29/2018 11:48 AM, Baolin Wang wrote: > Hi Jacek, > > On 29 August 2018 at 04:25, Jacek Anaszewski > wrote: >> On 08/25/2018 09:51 AM, Baolin Wang wrote: >>> On 25 August 2018 at 04:44, Jacek Anaszewski >>> wrote: On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Jacek Anaszewski
On 08/28/2018 11:13 PM, Bjorn Andersson wrote: > On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > >> On 08/25/2018 09:51 AM, Baolin Wang wrote: >>> On 25 August 2018 at 04:44, Jacek Anaszewski >>> wrote: On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2018-08-24 21:49:50,

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Jacek Anaszewski
On 08/28/2018 11:13 PM, Bjorn Andersson wrote: > On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > >> On 08/25/2018 09:51 AM, Baolin Wang wrote: >>> On 25 August 2018 at 04:44, Jacek Anaszewski >>> wrote: On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2018-08-24 21:49:50,

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Baolin Wang
Hi Jacek, On 29 August 2018 at 04:25, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: >> On 25 August 2018 at 04:44, Jacek Anaszewski >> wrote: >>> On 08/24/2018 10:12 PM, Pavel Machek wrote: On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-29 Thread Baolin Wang
Hi Jacek, On 29 August 2018 at 04:25, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: >> On 25 August 2018 at 04:44, Jacek Anaszewski >> wrote: >>> On 08/24/2018 10:12 PM, Pavel Machek wrote: On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Bjorn Andersson
On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: > > On 25 August 2018 at 04:44, Jacek Anaszewski > > wrote: > >> On 08/24/2018 10:12 PM, Pavel Machek wrote: > >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Bjorn Andersson
On Tue 28 Aug 13:25 PDT 2018, Jacek Anaszewski wrote: > On 08/25/2018 09:51 AM, Baolin Wang wrote: > > On 25 August 2018 at 04:44, Jacek Anaszewski > > wrote: > >> On 08/24/2018 10:12 PM, Pavel Machek wrote: > >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Bjorn Andersson
On Sat 25 Aug 00:51 PDT 2018, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: > > On 08/24/2018 10:12 PM, Pavel Machek wrote: > >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > >>> Hi Pavel, > >>> > >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: [..] > >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Bjorn Andersson
On Sat 25 Aug 00:51 PDT 2018, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: > > On 08/24/2018 10:12 PM, Pavel Machek wrote: > >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > >>> Hi Pavel, > >>> > >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: [..] > >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Jacek Anaszewski
On 08/25/2018 09:51 AM, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: >> On 08/24/2018 10:12 PM, Pavel Machek wrote: >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: Hi Pavel, On 08/24/2018 12:11 PM, Pavel Machek wrote: > Hi! > >> I

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-28 Thread Jacek Anaszewski
On 08/25/2018 09:51 AM, Baolin Wang wrote: > On 25 August 2018 at 04:44, Jacek Anaszewski > wrote: >> On 08/24/2018 10:12 PM, Pavel Machek wrote: >>> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: Hi Pavel, On 08/24/2018 12:11 PM, Pavel Machek wrote: > Hi! > >> I

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-25 Thread Baolin Wang
On 25 August 2018 at 04:44, Jacek Anaszewski wrote: > On 08/24/2018 10:12 PM, Pavel Machek wrote: >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: >>> Hi Pavel, >>> >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: Hi! > I think that it would be more flexible if software pattern

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-25 Thread Baolin Wang
On 25 August 2018 at 04:44, Jacek Anaszewski wrote: > On 08/24/2018 10:12 PM, Pavel Machek wrote: >> On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: >>> Hi Pavel, >>> >>> On 08/24/2018 12:11 PM, Pavel Machek wrote: Hi! > I think that it would be more flexible if software pattern

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Jacek Anaszewski
On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 08/24/2018 12:11 PM, Pavel Machek wrote: >>> Hi! >>> I think that it would be more flexible if software pattern fallback was applied in case of pattern_set failure.

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Jacek Anaszewski
On 08/24/2018 10:12 PM, Pavel Machek wrote: > On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 08/24/2018 12:11 PM, Pavel Machek wrote: >>> Hi! >>> I think that it would be more flexible if software pattern fallback was applied in case of pattern_set failure.

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Pavel Machek
On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > > On 08/24/2018 12:11 PM, Pavel Machek wrote: > > Hi! > > > >> I think that it would be more flexible if software pattern fallback > >> was applied in case of pattern_set failure. Otherwise, it would > >> lead to the situation

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Pavel Machek
On Fri 2018-08-24 21:49:50, Jacek Anaszewski wrote: > Hi Pavel, > > On 08/24/2018 12:11 PM, Pavel Machek wrote: > > Hi! > > > >> I think that it would be more flexible if software pattern fallback > >> was applied in case of pattern_set failure. Otherwise, it would > >> lead to the situation

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Jacek Anaszewski
Hi Pavel, On 08/24/2018 12:11 PM, Pavel Machek wrote: > Hi! > >> I think that it would be more flexible if software pattern fallback >> was applied in case of pattern_set failure. Otherwise, it would >> lead to the situation where LED class devices that support hardware >> blinking couldn't be

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Jacek Anaszewski
Hi Pavel, On 08/24/2018 12:11 PM, Pavel Machek wrote: > Hi! > >> I think that it would be more flexible if software pattern fallback >> was applied in case of pattern_set failure. Otherwise, it would >> lead to the situation where LED class devices that support hardware >> blinking couldn't be

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Pavel Machek
Hi! > I think that it would be more flexible if software pattern fallback > was applied in case of pattern_set failure. Otherwise, it would > lead to the situation where LED class devices that support hardware > blinking couldn't be applied the same set of patterns as LED class > devices that

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-24 Thread Pavel Machek
Hi! > I think that it would be more flexible if software pattern fallback > was applied in case of pattern_set failure. Otherwise, it would > lead to the situation where LED class devices that support hardware > blinking couldn't be applied the same set of patterns as LED class > devices that

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-10 Thread Baolin Wang
Hi Jacek, On 11 August 2018 at 02:10, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/10/2018 05:26 PM, Baolin Wang wrote: >> Hi Jacek, >> >> On 9 August 2018 at 21:21, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> On 08/09/2018 07:48 AM, Baolin Wang wrote: >>> [...] +static int

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-10 Thread Baolin Wang
Hi Jacek, On 11 August 2018 at 02:10, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/10/2018 05:26 PM, Baolin Wang wrote: >> Hi Jacek, >> >> On 9 August 2018 at 21:21, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> On 08/09/2018 07:48 AM, Baolin Wang wrote: >>> [...] +static int

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-10 Thread Jacek Anaszewski
Hi Baolin, On 08/10/2018 05:26 PM, Baolin Wang wrote: > Hi Jacek, > > On 9 August 2018 at 21:21, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 08/09/2018 07:48 AM, Baolin Wang wrote: >> [...] >>> +static int pattern_trig_start_pattern(struct pattern_trig_data *data, >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-10 Thread Jacek Anaszewski
Hi Baolin, On 08/10/2018 05:26 PM, Baolin Wang wrote: > Hi Jacek, > > On 9 August 2018 at 21:21, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 08/09/2018 07:48 AM, Baolin Wang wrote: >> [...] >>> +static int pattern_trig_start_pattern(struct pattern_trig_data *data, >>> +

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-10 Thread Baolin Wang
Hi Jacek, On 9 August 2018 at 21:21, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/09/2018 07:48 AM, Baolin Wang wrote: > [...] >> +static int pattern_trig_start_pattern(struct pattern_trig_data *data, >> + struct led_classdev *led_cdev) >> +{

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-10 Thread Baolin Wang
Hi Jacek, On 9 August 2018 at 21:21, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/09/2018 07:48 AM, Baolin Wang wrote: > [...] >> +static int pattern_trig_start_pattern(struct pattern_trig_data *data, >> + struct led_classdev *led_cdev) >> +{

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-09 Thread Jacek Anaszewski
Hi Baolin, On 08/09/2018 07:48 AM, Baolin Wang wrote: [...] > +static int pattern_trig_start_pattern(struct pattern_trig_data *data, > + struct led_classdev *led_cdev) > +{ > + if (!data->npatterns) > + return 0; > + >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-09 Thread Jacek Anaszewski
Hi Baolin, On 08/09/2018 07:48 AM, Baolin Wang wrote: [...] > +static int pattern_trig_start_pattern(struct pattern_trig_data *data, > + struct led_classdev *led_cdev) > +{ > + if (!data->npatterns) > + return 0; > + >

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-08 Thread Baolin Wang
Hi Jacek, On 9 August 2018 at 05:28, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/08/2018 08:01 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 8 August 2018 at 05:54, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for addressing the review remarks. >>> Since the patch set is

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-08 Thread Baolin Wang
Hi Jacek, On 9 August 2018 at 05:28, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/08/2018 08:01 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 8 August 2018 at 05:54, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for addressing the review remarks. >>> Since the patch set is

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-08 Thread Jacek Anaszewski
Hi Baolin, On 08/08/2018 08:01 AM, Baolin Wang wrote: > Hi Jacek, > > On 8 August 2018 at 05:54, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> Thank you for addressing the review remarks. >> Since the patch set is targeted for 4.19, then we have three weeks >> before it will be merged to the

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-08 Thread Jacek Anaszewski
Hi Baolin, On 08/08/2018 08:01 AM, Baolin Wang wrote: > Hi Jacek, > > On 8 August 2018 at 05:54, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> Thank you for addressing the review remarks. >> Since the patch set is targeted for 4.19, then we have three weeks >> before it will be merged to the

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-08 Thread Baolin Wang
Hi Jacek, On 8 August 2018 at 05:54, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for addressing the review remarks. > Since the patch set is targeted for 4.19, then we have three weeks > before it will be merged to the for-next anyway. That said, I propose > one more modification, please

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-08 Thread Baolin Wang
Hi Jacek, On 8 August 2018 at 05:54, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for addressing the review remarks. > Since the patch set is targeted for 4.19, then we have three weeks > before it will be merged to the for-next anyway. That said, I propose > one more modification, please

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-07 Thread Jacek Anaszewski
Hi Baolin, Thank you for addressing the review remarks. Since the patch set is targeted for 4.19, then we have three weeks before it will be merged to the for-next anyway. That said, I propose one more modification, please take a look below. On 08/06/2018 02:05 PM, Baolin Wang wrote: > Some LED

Re: [PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-07 Thread Jacek Anaszewski
Hi Baolin, Thank you for addressing the review remarks. Since the patch set is targeted for 4.19, then we have three weeks before it will be merged to the for-next anyway. That said, I propose one more modification, please take a look below. On 08/06/2018 02:05 PM, Baolin Wang wrote: > Some LED

[PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang ---

[PATCH v5 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang ---