Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-15 Thread Andrey Ryabinin
On 06/14/2016 09:46 AM, Luruo, Kuthonuzo wrote: >>> Next time, when/if you send patch series, send patches in one thread, i.e. >>> patches should be replies to the cover letter. >>> Your patches are not linked together, which makes them harder to track. > > Thanks for the tip; but doesn't this c

Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-15 Thread Andrey Ryabinin
On 06/10/2016 08:09 PM, Dmitry Vyukov wrote: > On Fri, Jun 10, 2016 at 7:03 PM, Andrey Ryabinin > wrote: >> >> >> On 06/09/2016 08:00 PM, Andrey Ryabinin wrote: >>> On 06/07/2016 09:03 PM, Kuthonuzo Luruo wrote: >>> >>> Next time, when/if you send patch series, send patches in one thread, i.e.

RE: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-14 Thread Luruo, Kuthonuzo
> > Next time, when/if you send patch series, send patches in one thread, i.e. > > patches should be replies to the cover letter. > > Your patches are not linked together, which makes them harder to track. Thanks for the tip; but doesn't this conflict with the advice in https://www.kernel.org/doc/

Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-13 Thread Alexander Potapenko
On Fri, Jun 10, 2016 at 7:03 PM, Andrey Ryabinin wrote: > > > On 06/09/2016 08:00 PM, Andrey Ryabinin wrote: >> On 06/07/2016 09:03 PM, Kuthonuzo Luruo wrote: >> >> Next time, when/if you send patch series, send patches in one thread, i.e. >> patches should be replies to the cover letter. >> Your

Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-10 Thread Andrey Ryabinin
On 06/09/2016 08:00 PM, Andrey Ryabinin wrote: > On 06/07/2016 09:03 PM, Kuthonuzo Luruo wrote: > > Next time, when/if you send patch series, send patches in one thread, i.e. > patches should be replies to the cover letter. > Your patches are not linked together, which makes them harder to trac

Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-10 Thread Dmitry Vyukov
On Fri, Jun 10, 2016 at 7:03 PM, Andrey Ryabinin wrote: > > > On 06/09/2016 08:00 PM, Andrey Ryabinin wrote: >> On 06/07/2016 09:03 PM, Kuthonuzo Luruo wrote: >> >> Next time, when/if you send patch series, send patches in one thread, i.e. >> patches should be replies to the cover letter. >> Your

RE: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-09 Thread Luruo, Kuthonuzo
> > Currently, KASAN may fail to detect concurrent deallocations of the same > > object due to a race in kasan_slab_free(). This patch makes double-free > > detection more reliable by serializing access to KASAN object metadata. > > New functions kasan_meta_lock() and kasan_meta_unlock() are provid

Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-09 Thread Andrey Ryabinin
On 06/07/2016 09:03 PM, Kuthonuzo Luruo wrote: Next time, when/if you send patch series, send patches in one thread, i.e. patches should be replies to the cover letter. Your patches are not linked together, which makes them harder to track. > Currently, KASAN may fail to detect concurrent deall

Re: [PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-09 Thread Alexander Potapenko
On Tue, Jun 7, 2016 at 8:03 PM, Kuthonuzo Luruo wrote: > Currently, KASAN may fail to detect concurrent deallocations of the same > object due to a race in kasan_slab_free(). This patch makes double-free > detection more reliable by serializing access to KASAN object metadata. > New functions kasa

[PATCH v5 1/2] mm, kasan: improve double-free detection

2016-06-07 Thread Kuthonuzo Luruo
Currently, KASAN may fail to detect concurrent deallocations of the same object due to a race in kasan_slab_free(). This patch makes double-free detection more reliable by serializing access to KASAN object metadata. New functions kasan_meta_lock() and kasan_meta_unlock() are provided to lock/unloc