Hi Hans.
Thanks for your suggestion helping to improve the patch.
On 3/24/21 7:39 AM, Hans de Goede wrote:
Hi,
On 3/24/21 12:19 PM, Hans de Goede wrote:
Hi,
On 3/22/21 10:38 AM, Perry Yuan wrote:
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware
Hi Pierre
Thanks for your review .
I changed the patch and explain the review comments as below
(Maybe the mail format has problem, sent from one new system thunderbird :)
On 3/23/21 2:57 PM, Pierre-Louis Bossart wrote:
Minor comments below.
On 3/22/21 4:38 AM, Perry Yuan wrote:
From:
@perex.cz;
> ti...@suse.com; mgr...@linux.intel.com; Limonciello, Mario
> Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org;
> linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org
> Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support
...@perex.cz; ti...@suse.com;
>> mgr...@linux.intel.com; Limonciello, Mario
>> Cc: alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org;
>> lgirdw...@gmail.com; platform-driver-...@vger.kernel.org;
>> broo...@kernel.org
>> Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy:
; Cc: alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org;
> lgirdw...@gmail.com; platform-driver-...@vger.kernel.org;
> broo...@kernel.org
> Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell
> hardware privacy
>
>
> [EXTERNAL EMAIL]
>
> H
Hi,
On 3/24/21 12:19 PM, Hans de Goede wrote:
> Hi,
>
> On 3/22/21 10:38 AM, Perry Yuan wrote:
>> From: Perry Yuan
>>
>> add support for Dell privacy driver for the Dell units equipped
>> hardware privacy design, which protect users privacy of audio and
>> camera from hardware level. Once the
Hi,
On 3/22/21 10:38 AM, Perry Yuan wrote:
> From: Perry Yuan
>
> add support for Dell privacy driver for the Dell units equipped
> hardware privacy design, which protect users privacy of audio and
> camera from hardware level. Once the audio or camera privacy mode
> activated, any applications
Hi,
On 3/23/21 7:57 PM, Pierre-Louis Bossart wrote:
> Minor comments below.
> +int __init dell_privacy_acpi_init(void)
>
> is the __init necessary? You call this routine from another which already has
> this qualifier.
Yes this is necessary, all functions which are only used during
Minor comments below.
On 3/22/21 4:38 AM, Perry Yuan wrote:
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. Once the audio or camera privacy mode
activated, any
..@linux.intel.com;
> Limonciello, Mario
> Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org;
> linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org
> Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell
> hardware privacy
>
>
>
On 3/22/21 2:38 AM, Perry Yuan wrote:
> From: Perry Yuan
>
> diff --git a/drivers/platform/x86/dell/Kconfig
> b/drivers/platform/x86/dell/Kconfig
> index e0a55337f51a..0e0f1eb35bd6 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -204,4 +204,20 @@
From: Perry Yuan
add support for Dell privacy driver for the Dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. Once the audio or camera privacy mode
activated, any applications will not get any audio or video stream
when user
12 matches
Mail list logo
