Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Rob Clark
On Tue, Sep 23, 2014 at 10:12 PM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao Looks like my comments are addressed, so: Reviewed-by: Rob Clark > --- > Changes in v2: > - use the component framework to defer main drm

Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Rob Clark
On Tue, Sep 23, 2014 at 10:12 PM, Mark yao mark@rock-chips.com wrote: This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao mark@rock-chips.com Looks like my comments are addressed, so: Reviewed-by: Rob Clark robdcl...@gmail.com --- Changes

Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Kurtz
Hi Mark, Please review comments inline... On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all

Re: [PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Kurtz
Hi Mark, Please review comments inline... On Wed, Sep 24, 2014 at 10:12 AM, Mark yao mark@rock-chips.com wrote: This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao mark@rock-chips.com --- Changes in v2: - use the component framework to

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao mark@rock-chips.com --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma