Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-11 Thread Hans de Goede
Hi, On 11/10/20 11:17 PM, Doug Anderson wrote: > Hi, > > On Tue, Nov 10, 2020 at 1:01 AM Hans de Goede wrote: >> >> Hi, >> >> On 11/9/20 10:36 PM, Douglas Anderson wrote: >>> This patch rejiggers the i2c-hid code so that the OF (Open Firmware >>> aka Device Tree) and ACPI support is separated

Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-11 Thread Hans de Goede
Hi, On 11/11/20 1:04 AM, Dmitry Torokhov wrote: > On Tue, Nov 10, 2020 at 02:17:27PM -0800, Doug Anderson wrote: >> Hi, >> >> On Tue, Nov 10, 2020 at 1:01 AM Hans de Goede wrote: >>> >>> Hi, >>> >>> On 11/9/20 10:36 PM, Douglas Anderson wrote: This patch rejiggers the i2c-hid code so that

Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-10 Thread Dmitry Torokhov
On Tue, Nov 10, 2020 at 02:17:27PM -0800, Doug Anderson wrote: > Hi, > > On Tue, Nov 10, 2020 at 1:01 AM Hans de Goede wrote: > > > > Hi, > > > > On 11/9/20 10:36 PM, Douglas Anderson wrote: > > > This patch rejiggers the i2c-hid code so that the OF (Open Firmware > > > aka Device Tree) and ACPI

Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-10 Thread Doug Anderson
Hi, On Tue, Nov 10, 2020 at 1:01 AM Hans de Goede wrote: > > Hi, > > On 11/9/20 10:36 PM, Douglas Anderson wrote: > > This patch rejiggers the i2c-hid code so that the OF (Open Firmware > > aka Device Tree) and ACPI support is separated out a bit. The OF and > > ACPI drivers are now separate

Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-10 Thread Hans de Goede
Hi, On 11/9/20 10:36 PM, Douglas Anderson wrote: > This patch rejiggers the i2c-hid code so that the OF (Open Firmware > aka Device Tree) and ACPI support is separated out a bit. The OF and > ACPI drivers are now separate modules that wrap the core module. > > Essentially, what we're doing

Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-09 Thread Doug Anderson
Hi, On Mon, Nov 9, 2020 at 1:37 PM Douglas Anderson wrote: > > +int i2c_hid_acpi_probe(struct i2c_client *client, > + const struct i2c_device_id *dev_id) > +{ > + struct device *dev = >dev; > + struct i2c_hid_acpi *ihid_acpi; > + u16 hid_descriptor_address;

[PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

2020-11-09 Thread Douglas Anderson
This patch rejiggers the i2c-hid code so that the OF (Open Firmware aka Device Tree) and ACPI support is separated out a bit. The OF and ACPI drivers are now separate modules that wrap the core module. Essentially, what we're doing here: * Make "power up" and "power down" a function that can be