Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-22 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > On Sun, 21 Feb 2016, Robert Jarzmik wrote: > Please, have a look at > http://git.linuxtv.org/gliakhovetski/v4l-dvb.git/log/?h=for-4.6-2 > If all is good there, no need for a v6 Thanks for fixing the *_dma_irq() mess, and sorry for that.

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-22 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > On Sun, 21 Feb 2016, Robert Jarzmik wrote: > Please, have a look at > http://git.linuxtv.org/gliakhovetski/v4l-dvb.git/log/?h=for-4.6-2 > If all is good there, no need for a v6 Thanks for fixing the *_dma_irq() mess, and sorry for that. And I just tested your

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> Okay Guennadi, I retested this version on top of v4.5-rc2, still good to >> go. There is a minor conflict in the includes since this submission, and I >> can >> repost a v6 which solves it. > > How did you test it with that patchg #3?? I

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> Okay Guennadi, I retested this version on top of v4.5-rc2, still good to >> go. There is a minor conflict in the includes since this submission, and I >> can >> repost a v6 which solves it. > > How did you test it with that patchg #3?? I rebased my patches on

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Guennadi Liakhovetski
On Mon, 8 Feb 2016, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > Hi Robert, > > > > On Tue, 27 Oct 2015, Robert Jarzmik wrote: > > > >> Guennadi Liakhovetski writes: > >> > >> > Hi Robert, > >> > > >> > Didn't you tell me, that your

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Guennadi Liakhovetski
On Mon, 8 Feb 2016, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > Hi Robert, > > > > On Tue, 27 Oct 2015, Robert Jarzmik wrote: > > > >> Guennadi Liakhovetski writes: > >> > >> > Hi Robert, > >> > > >> > Didn't you tell me, that your dmaengine patch got rejected and therefore >

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Guennadi Liakhovetski
On Sun, 21 Feb 2016, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > >> Okay Guennadi, I retested this version on top of v4.5-rc2, still good to > >> go. There is a minor conflict in the includes since this submission, and I > >> can > >> repost a v6 which

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Guennadi Liakhovetski
On Sun, 21 Feb 2016, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > >> Okay Guennadi, I retested this version on top of v4.5-rc2, still good to > >> go. There is a minor conflict in the includes since this submission, and I > >> can > >> repost a v6 which solves it. > > > > How did

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-08 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > On Tue, 27 Oct 2015, Robert Jarzmik wrote: > >> Guennadi Liakhovetski writes: >> >> > Hi Robert, >> > >> > Didn't you tell me, that your dmaengine patch got rejected and therefore >> > these your patches were on hold? >> They were reverted, and

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-08 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > On Tue, 27 Oct 2015, Robert Jarzmik wrote: > >> Guennadi Liakhovetski writes: >> >> > Hi Robert, >> > >> > Didn't you tell me, that your dmaengine patch got rejected and therefore >> > these your

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-29 Thread Guennadi Liakhovetski
Hi Robert, On Tue, 27 Oct 2015, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > Hi Robert, > > > > Didn't you tell me, that your dmaengine patch got rejected and therefore > > these your patches were on hold? > They were reverted, and then revamped into DMA_CTRL_REUSE, upstreamed

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-29 Thread Guennadi Liakhovetski
Hi Robert, On Tue, 27 Oct 2015, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > Hi Robert, > > > > Didn't you tell me, that your dmaengine patch got rejected and therefore > > these your patches were on hold? > They were reverted, and then revamped into

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > Didn't you tell me, that your dmaengine patch got rejected and therefore > these your patches were on hold? They were reverted, and then revamped into DMA_CTRL_REUSE, upstreamed and merged, as in the commit 272420214d26 ("dmaengine: Add

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Guennadi Liakhovetski
Hi Robert, Didn't you tell me, that your dmaengine patch got rejected and therefore these your patches were on hold? Thanks Guennadi On Sat, 24 Oct 2015, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Fix the error path where the video buffer wasn't allocated nor > > mapped. In this

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Guennadi Liakhovetski
Hi Robert, Didn't you tell me, that your dmaengine patch got rejected and therefore these your patches were on hold? Thanks Guennadi On Sat, 24 Oct 2015, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Fix the error path where the video buffer wasn't allocated

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > Didn't you tell me, that your dmaengine patch got rejected and therefore > these your patches were on hold? They were reverted, and then revamped into DMA_CTRL_REUSE, upstreamed and merged, as in the commit 272420214d26

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-24 Thread Robert Jarzmik
Robert Jarzmik writes: > Fix the error path where the video buffer wasn't allocated nor > mapped. In this case, in the driver free path don't try to unmap memory > which was not mapped in the first place. > > Signed-off-by: Robert Jarzmik > --- > Since v3: take into account the 2 paths

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-24 Thread Robert Jarzmik
Robert Jarzmik writes: > Fix the error path where the video buffer wasn't allocated nor > mapped. In this case, in the driver free path don't try to unmap memory > which was not mapped in the first place. > > Signed-off-by: Robert Jarzmik > --- >

[PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-09-06 Thread Robert Jarzmik
Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik --- Since v3: take into account the 2 paths possibilities to free_buffer() ---

[PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-09-06 Thread Robert Jarzmik
Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik --- Since v3: take into account the 2 paths possibilities to