Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

2021-04-04 Thread Vaittinen, Matti
On Sun, 2021-04-04 at 19:21 +0300, Matti Vaittinen wrote: > On Fri, 2021-04-02 at 18:42 +0100, Mark Brown wrote: > > On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote: > > > > Acked-by: Mark Brown > > > > but... > > Do you want me to respin the series or do you think this can be

Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

2021-04-04 Thread Vaittinen, Matti
On Fri, 2021-04-02 at 18:42 +0100, Mark Brown wrote: > On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote: > > Acked-by: Mark Brown > > but... Do you want me to respin the series or do you think this can be applied as-is and fixed by a follow-up? Best Regards Matti

Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

2021-04-02 Thread Mark Brown
On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote: Acked-by: Mark Brown but... > @@ -0,0 +1,676 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright 2014 Embest Technology Co. Ltd. Inc. Please make the entire comment a C++ one so things look more intentional. >

[PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

2021-03-29 Thread Matti Vaittinen
Support voltage control for regulators on ROHM BD71815 PMIC. ROHM BD71815 contains 5 bucks, 7 LDOs and a boost (intended for LED). Bucks 1 and 2 support HW state based voltage level and enable states. Other regulators support HW state based enable states. All bucks and LDOs 1-5 allow voltage