Re: [PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

On 24 March 2018 at 23:19, Wolfram Sang wrote: > Hi Ard, > >> +static int synquacer_i2c_master_start(struct synquacer_i2c *i2c, >> + struct i2c_msg *pmsg) >> +{ >> + unsigned char bsr, bcr; >> + >> + if (pmsg->flags & I2C_M_RD) >> +

Re: [PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

On 24 March 2018 at 23:19, Wolfram Sang wrote: > Hi Ard, > >> +static int synquacer_i2c_master_start(struct synquacer_i2c *i2c, >> + struct i2c_msg *pmsg) >> +{ >> + unsigned char bsr, bcr; >> + >> + if (pmsg->flags & I2C_M_RD) >> +

Re: [PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

My code checkers mention this: CPPCHECK drivers/i2c/busses/i2c-synquacer.c:422: style: Checking if unsigned variable 'timeout' is less than zero. CC drivers/i2c/busses/i2c-synquacer.o drivers/i2c/busses/i2c-synquacer.c: In function ‘synquacer_i2c_probe’:

Re: [PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

My code checkers mention this: CPPCHECK drivers/i2c/busses/i2c-synquacer.c:422: style: Checking if unsigned variable 'timeout' is less than zero. CC drivers/i2c/busses/i2c-synquacer.o drivers/i2c/busses/i2c-synquacer.c: In function ‘synquacer_i2c_probe’:

Re: [PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

Hi Ard, > +static int synquacer_i2c_master_start(struct synquacer_i2c *i2c, > + struct i2c_msg *pmsg) > +{ > + unsigned char bsr, bcr; > + > + if (pmsg->flags & I2C_M_RD) > + writeb((pmsg->addr << 1) | 1, > +i2c->base +

Re: [PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

Hi Ard, > +static int synquacer_i2c_master_start(struct synquacer_i2c *i2c, > + struct i2c_msg *pmsg) > +{ > + unsigned char bsr, bcr; > + > + if (pmsg->flags & I2C_M_RD) > + writeb((pmsg->addr << 1) | 1, > +i2c->base +

[PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

This is a cleaned up version of the I2C controller driver for the Fujitsu F_I2C IP, which was never supported upstream, and has now been incorporated into the Socionext SynQuacer SoC. Signed-off-by: Ard Biesheuvel Reviewed-by: Andy Shevchenko

[PATCH v5 2/2] i2c: add support for Socionext SynQuacer I2C controller

This is a cleaned up version of the I2C controller driver for the Fujitsu F_I2C IP, which was never supported upstream, and has now been incorporated into the Socionext SynQuacer SoC. Signed-off-by: Ard Biesheuvel Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/Kconfig | 10 +