Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

2021-02-08 Thread Matthew Wilcox
On Mon, Feb 08, 2021 at 08:17:34PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 08, 2021 at 03:22:44PM +, Matthew Wilcox wrote: > > On Mon, Feb 08, 2021 at 03:14:28PM +, Kalesh Singh wrote: > > > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\n", > > > + seq_printf(m,

Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

2021-02-08 Thread Alexey Dobriyan
On Mon, Feb 08, 2021 at 03:22:44PM +, Matthew Wilcox wrote: > On Mon, Feb 08, 2021 at 03:14:28PM +, Kalesh Singh wrote: > > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\n", > > + seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\ninode_no:\t%lu\n", > > You changed it

Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

2021-02-08 Thread Kalesh Singh
On Mon, Feb 8, 2021 at 10:22 AM Matthew Wilcox wrote: > > On Mon, Feb 08, 2021 at 03:14:28PM +, Kalesh Singh wrote: > > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\n", > > + seq_printf(m, > > "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\ninode_no:\t%lu\n", > > You changed it

Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

2021-02-08 Thread Matthew Wilcox
On Mon, Feb 08, 2021 at 03:14:28PM +, Kalesh Singh wrote: > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\n", > + seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\ninode_no:\t%lu\n", You changed it everywhere but here ...

[PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

2021-02-08 Thread Kalesh Singh
And 'inode_no' field to /proc//fdinfo/ and /proc//task//fdinfo/. The inode numbers can be used to uniquely identify DMA buffers in user space and avoids a dependency on /proc//fd/* when accounting per-process DMA buffer sizes. Signed-off-by: Kalesh Singh Acked-by: Randy Dunlap --- Changes in