Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-12 Thread Uwe Kleine-König
Hello, On Thu, Feb 14, 2019 at 04:59:03PM +0100, Uwe Kleine-König wrote: > On Wed, Feb 13, 2019 at 01:37:03PM +0100, Thierry Reding wrote: > > On Thu, Feb 07, 2019 at 11:16:57AM +0100, Uwe Kleine-König wrote: > > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > > [...] > > > > diff -

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-14 Thread Uwe Kleine-König
On Wed, Feb 13, 2019 at 01:37:03PM +0100, Thierry Reding wrote: > On Thu, Feb 07, 2019 at 11:16:57AM +0100, Uwe Kleine-König wrote: > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > [...] > > > diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c > [...] > > > + writel(va

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Uwe Kleine-König
On Wed, Feb 13, 2019 at 01:34:05PM +0100, Thierry Reding wrote: > On Mon, Feb 11, 2019 at 01:29:54PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Mon, Feb 11, 2019 at 04:56:27PM +0530, Yash Shah wrote: > > > On Thu, Feb 7, 2019 at 3:47 PM Uwe Kleine-König > > > wrote: > > > > On Tue, Jan

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Thierry Reding
On Thu, Feb 07, 2019 at 11:16:57AM +0100, Uwe Kleine-König wrote: > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: [...] > > diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c [...] > > + writel(val, pwm->regs + PWM_SIFIVE_PWMCFG); > > + > > + writel(frac, pwm->regs +

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Thierry Reding
On Mon, Feb 11, 2019 at 01:29:54PM +0100, Uwe Kleine-König wrote: > Hello, > > On Mon, Feb 11, 2019 at 04:56:27PM +0530, Yash Shah wrote: > > On Thu, Feb 7, 2019 at 3:47 PM Uwe Kleine-König > > wrote: > > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > > > > +struct pwm_sifive_ddat

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-11 Thread Uwe Kleine-König
Hello, On Mon, Feb 11, 2019 at 04:56:27PM +0530, Yash Shah wrote: > On Thu, Feb 7, 2019 at 3:47 PM Uwe Kleine-König > wrote: > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > > > +struct pwm_sifive_ddata { > > > + struct pwm_chip chip; > > > + struct notifier_block notifier

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-11 Thread Yash Shah
On Thu, Feb 7, 2019 at 3:47 PM Uwe Kleine-König wrote: > > Hello, > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > > Signed-off-by: Wesley W. Terpstra > > [Atish: Various fixes and code cleanup] > > S

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-07 Thread Uwe Kleine-König
Hello, On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra > Signed-off-by: Yash Shah > --- > drivers/

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-07 Thread Yash Shah
On Wed, Feb 6, 2019 at 6:14 PM Thierry Reding wrote: > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > [...] > > diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c > [...] > > +static void pwm_sifive_update_clock(struct pwm_sifive_ddata *pwm, > > +

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-06 Thread Thierry Reding
On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: [...] > diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c [...] > +static void pwm_sifive_update_clock(struct pwm_sifive_ddata *pwm, > + unsigned long rate) > +{ > + /* (1 << (16+scale)) *

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-05 Thread kbuild test robot
Hi Yash, Thank you for the patch! Yet something to improve: [auto build test ERROR on pwm/for-next] [also build test ERROR on v5.0-rc4 next-20190205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-05 Thread kbuild test robot
Hi Yash, Thank you for the patch! Yet something to improve: [auto build test ERROR on pwm/for-next] [also build test ERROR on v5.0-rc4 next-20190204] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

[PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-01-29 Thread Yash Shah
Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. Signed-off-by: Wesley W. Terpstra [Atish: Various fixes and code cleanup] Signed-off-by: Atish Patra Signed-off-by: Yash Shah --- drivers/pwm/Kconfig | 11 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sifive