Re: [PATCH v5 2/2] tracing: add additional marks to signal very large time

2014-11-20 Thread Steven Rostedt
On Thu, 20 Nov 2014 15:38:46 +0900 Byungchul Park wrote: > > I think it's impossible since it's always true that 'd >= 0'. > > > > If someone won't define "MARK(0ULL, ' ')", then i think it can happen. :) > Actually, remove the "MARK(0ULL, ' ')" and keep the return value as is. But clean it

Re: [PATCH v5 2/2] tracing: add additional marks to signal very large time

2014-11-20 Thread Steven Rostedt
On Thu, 20 Nov 2014 15:05:43 +0900 Namhyung Kim wrote: > Hi Steve and Byungchul, > > On Wed, 19 Nov 2014 20:06:04 -0500, Steven Rostedt wrote: > > On Thu, 20 Nov 2014 09:15:35 +0900 > > byungchul.p...@lge.com wrote: > >> -static unsigned long preempt_mark_thresh_us = 100; > >> +#undef MARK > >>

Re: [PATCH v5 2/2] tracing: add additional marks to signal very large time

2014-11-19 Thread Byungchul Park
Hello, On Thu, Nov 20, 2014 at 03:05:43PM +0900, Namhyung Kim wrote: > Hi Steve and Byungchul, > > On Wed, 19 Nov 2014 20:06:04 -0500, Steven Rostedt wrote: > > On Thu, 20 Nov 2014 09:15:35 +0900 > > byungchul.p...@lge.com wrote: > >> -static unsigned long preempt_mark_thresh_us = 100; > >> +#und

Re: [PATCH v5 2/2] tracing: add additional marks to signal very large time

2014-11-19 Thread Namhyung Kim
Hi Steve and Byungchul, On Wed, 19 Nov 2014 20:06:04 -0500, Steven Rostedt wrote: > On Thu, 20 Nov 2014 09:15:35 +0900 > byungchul.p...@lge.com wrote: >> -static unsigned long preempt_mark_thresh_us = 100; >> +#undef MARK >> +#define MARK(v, s) {.val = v, .sym = s} >> +/* trace overhead mark */ >>

Re: [PATCH v5 2/2] tracing: add additional marks to signal very large time

2014-11-19 Thread Steven Rostedt
On Thu, 20 Nov 2014 09:15:35 +0900 byungchul.p...@lge.com wrote: > From: Byungchul Park > > Currently, function graph tracer prints "!" or "+" just before > function execution time to signal a function overhead, depending > on the time. And some tracers tracing latency also print "!" or > "+" ju

[PATCH v5 2/2] tracing: add additional marks to signal very large time

2014-11-19 Thread byungchul . park
From: Byungchul Park Currently, function graph tracer prints "!" or "+" just before function execution time to signal a function overhead, depending on the time. And some tracers tracing latency also print "!" or "+" just after time to signal overhead, depending on the interval between events. Ev