Re: [PATCH v5 2/3] mtd: add the support to parse out the full-id nand type

2013-03-13 Thread Brian Norris
Hi Huang, A few nitpicks, and a few real comments. On Wed, Mar 13, 2013 at 7:59 PM, Huang Shijie wrote: > When we meet a full-id nand type which @mfr_id is true, we can use > the find_full_id_nand() to parse out the neccessary information for a s/neccessary/necessary > nand chip. > > If we

[PATCH v5 2/3] mtd: add the support to parse out the full-id nand type

2013-03-13 Thread Huang Shijie
When we meet a full-id nand type which @mfr_id is true, we can use the find_full_id_nand() to parse out the neccessary information for a nand chip. If we meet a non full-id nand type, we can handle it in the lagacy way. Signed-off-by: Huang Shijie --- drivers/mtd/nand/nand_base.c | 36

[PATCH v5 2/3] mtd: add the support to parse out the full-id nand type

2013-03-13 Thread Huang Shijie
When we meet a full-id nand type which @mfr_id is true, we can use the find_full_id_nand() to parse out the neccessary information for a nand chip. If we meet a non full-id nand type, we can handle it in the lagacy way. Signed-off-by: Huang Shijie b32...@freescale.com ---

Re: [PATCH v5 2/3] mtd: add the support to parse out the full-id nand type

2013-03-13 Thread Brian Norris
Hi Huang, A few nitpicks, and a few real comments. On Wed, Mar 13, 2013 at 7:59 PM, Huang Shijie b32...@freescale.com wrote: When we meet a full-id nand type which @mfr_id is true, we can use the find_full_id_nand() to parse out the neccessary information for a s/neccessary/necessary nand