Re: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file

2018-04-17 Thread Jerome Brunet
On Tue, 2018-04-17 at 16:16 +0800, Yixun Lan wrote: > Hi Jerome > > On 04/16/18 18:38, Jerome Brunet wrote: > > > + */ > > > + for (clkid = 0; clkid < data->num_clks; clkid++) { > > > + data->clks[clkid]->map = regmap; > > > + > > > + ret = devm_clk_hw_register(dev, data->hw_data-

Re: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file

2018-04-17 Thread Yixun Lan
Hi jerome On 04/16/18 19:34, Jerome Brunet wrote: > On Mon, 2018-04-09 at 22:37 +0800, Yixun Lan wrote: >> We try to refactor the common code into one dedicated file, >> while preparing to add new Meson-AXG aoclk driver, this would >> help us to better share the code by all aoclk drivers. >> >> Su

Re: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file

2018-04-17 Thread Yixun Lan
Hi Jerome On 04/16/18 18:38, Jerome Brunet wrote: >> + */ >> +for (clkid = 0; clkid < data->num_clks; clkid++) { >> +data->clks[clkid]->map = regmap; >> + >> +ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]); >> +if (ret) >> +

Re: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file

2018-04-16 Thread Jerome Brunet
On Mon, 2018-04-09 at 22:37 +0800, Yixun Lan wrote: > We try to refactor the common code into one dedicated file, > while preparing to add new Meson-AXG aoclk driver, this would > help us to better share the code by all aoclk drivers. > > Suggested-by: Jerome Brunet > Signed-off-by: Yixun Lan >

Re: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file

2018-04-16 Thread Jerome Brunet
On Mon, 2018-04-09 at 22:37 +0800, Yixun Lan wrote: > We try to refactor the common code into one dedicated file, > while preparing to add new Meson-AXG aoclk driver, this would > help us to better share the code by all aoclk drivers. > > Suggested-by: Jerome Brunet > Signed-off-by: Yixun Lan >

[PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file

2018-04-09 Thread Yixun Lan
We try to refactor the common code into one dedicated file, while preparing to add new Meson-AXG aoclk driver, this would help us to better share the code by all aoclk drivers. Suggested-by: Jerome Brunet Signed-off-by: Yixun Lan --- drivers/clk/meson/Kconfig | 7 drivers/clk/meson/