Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2021-01-08 Thread Tomasz Figa
On Wed, Dec 23, 2020 at 9:04 PM Helen Koike wrote: > > Hi Tomasz, > > On 12/21/20 12:13 AM, Tomasz Figa wrote: > > On Thu, Dec 17, 2020 at 10:20 PM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > >> Thanks for your comments, I have a few questions below. > >> > >> On 12/16/20 12:13 AM, Tomasz

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-23 Thread Helen Koike
Hi Tomasz, On 12/21/20 12:13 AM, Tomasz Figa wrote: > On Thu, Dec 17, 2020 at 10:20 PM Helen Koike > wrote: >> >> Hi Tomasz, >> >> Thanks for your comments, I have a few questions below. >> >> On 12/16/20 12:13 AM, Tomasz Figa wrote: >>> On Tue, Dec 15, 2020 at 11:37 PM Helen Koike >>> wrote:

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-20 Thread Tomasz Figa
On Thu, Dec 17, 2020 at 10:20 PM Helen Koike wrote: > > Hi Tomasz, > > Thanks for your comments, I have a few questions below. > > On 12/16/20 12:13 AM, Tomasz Figa wrote: > > On Tue, Dec 15, 2020 at 11:37 PM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > >> On 12/14/20 7:46 AM, Tomasz Figa

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-17 Thread Helen Koike
Hi Tomasz, Thanks for your comments, I have a few questions below. On 12/16/20 12:13 AM, Tomasz Figa wrote: > On Tue, Dec 15, 2020 at 11:37 PM Helen Koike > wrote: >> >> Hi Tomasz, >> >> On 12/14/20 7:46 AM, Tomasz Figa wrote: >>> On Fri, Dec 4, 2020 at 4:52 AM Helen Koike >>> wrote: >>>

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Tomasz Figa
On Tue, Dec 15, 2020 at 11:37 PM Helen Koike wrote: > > Hi Tomasz, > > On 12/14/20 7:46 AM, Tomasz Figa wrote: > > On Fri, Dec 4, 2020 at 4:52 AM Helen Koike > > wrote: > >> > >> Hi, > >> > >> Please see my 2 points below (about v4l2_ext_buffer and another about > >> timestamp). > >> > >> On 12

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Helen Koike
Hi Tomasz, On 12/14/20 7:46 AM, Tomasz Figa wrote: > On Fri, Dec 4, 2020 at 4:52 AM Helen Koike wrote: >> >> Hi, >> >> Please see my 2 points below (about v4l2_ext_buffer and another about >> timestamp). >> >> On 12/3/20 12:11 PM, Hans Verkuil wrote: >>> On 23/11/2020 18:40, Helen Koike wrote: >

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Tomasz Figa
On Mon, Dec 14, 2020 at 10:24 PM Helen Koike wrote: > > Hi Tomasz, > > Thank you for your comments, > > On 12/14/20 7:36 AM, Tomasz Figa wrote: > > On Tue, Nov 24, 2020 at 5:33 AM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > >> > >> On 11/20/20 8:14 AM, Tomasz Figa wrote: > >>> Hi Helen, >

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Helen Koike
Hi Tomasz, Thank you for your comments, On 12/14/20 7:36 AM, Tomasz Figa wrote: > On Tue, Nov 24, 2020 at 5:33 AM Helen Koike wrote: >> >> Hi Tomasz, >> >> >> On 11/20/20 8:14 AM, Tomasz Figa wrote: >>> Hi Helen, >>> >>> On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: From: Han

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 4:52 AM Helen Koike wrote: > > Hi, > > Please see my 2 points below (about v4l2_ext_buffer and another about > timestamp). > > On 12/3/20 12:11 PM, Hans Verkuil wrote: > > On 23/11/2020 18:40, Helen Koike wrote: > >> > >> > >> On 11/23/20 12:46 PM, Tomasz Figa wrote: > >>>

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 12:11 AM Hans Verkuil wrote: > > On 23/11/2020 18:40, Helen Koike wrote: > > > > > > On 11/23/20 12:46 PM, Tomasz Figa wrote: > >> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike > >> wrote: > >>> > >>> Hi Hans, > >>> > >>> Thank you for your review. > >>> > >>> On 9/9/20 9:2

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Tue, Nov 24, 2020 at 5:33 AM Helen Koike wrote: > > Hi Tomasz, > > > On 11/20/20 8:14 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: > >> From: Hans Verkuil > >> > >> Those extended buffer ops have several purpose: > >> 1/ Fix y2038 is

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-03 Thread Helen Koike
Hi, Please see my 2 points below (about v4l2_ext_buffer and another about timestamp). On 12/3/20 12:11 PM, Hans Verkuil wrote: > On 23/11/2020 18:40, Helen Koike wrote: >> >> >> On 11/23/20 12:46 PM, Tomasz Figa wrote: >>> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike >>> wrote: Hi Ha

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-03 Thread Hans Verkuil
On 23/11/2020 18:40, Helen Koike wrote: > > > On 11/23/20 12:46 PM, Tomasz Figa wrote: >> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike >> wrote: >>> >>> Hi Hans, >>> >>> Thank you for your review. >>> >>> On 9/9/20 9:27 AM, Hans Verkuil wrote: Hi Helen, Again I'm just reviewing t

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-23 Thread Helen Koike
Hi Tomasz, On 11/20/20 8:14 AM, Tomasz Figa wrote: > Hi Helen, > > On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: >> From: Hans Verkuil >> >> Those extended buffer ops have several purpose: >> 1/ Fix y2038 issues by converting the timestamp into an u64 counting >>the number of

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-23 Thread Helen Koike
On 11/23/20 12:46 PM, Tomasz Figa wrote: > On Tue, Nov 24, 2020 at 12:08 AM Helen Koike > wrote: >> >> Hi Hans, >> >> Thank you for your review. >> >> On 9/9/20 9:27 AM, Hans Verkuil wrote: >>> Hi Helen, >>> >>> Again I'm just reviewing the uAPI. >>> >>> On 04/08/2020 21:29, Helen Koike wrote:

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-23 Thread Tomasz Figa
On Tue, Nov 24, 2020 at 12:08 AM Helen Koike wrote: > > Hi Hans, > > Thank you for your review. > > On 9/9/20 9:27 AM, Hans Verkuil wrote: > > Hi Helen, > > > > Again I'm just reviewing the uAPI. > > > > On 04/08/2020 21:29, Helen Koike wrote: > >> From: Hans Verkuil > >> > >> Those extended buff

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-23 Thread Helen Koike
Hi Hans, Thank you for your review. On 9/9/20 9:27 AM, Hans Verkuil wrote: > Hi Helen, > > Again I'm just reviewing the uAPI. > > On 04/08/2020 21:29, Helen Koike wrote: >> From: Hans Verkuil >> >> Those extended buffer ops have several purpose: >> 1/ Fix y2038 issues by converting the timesta

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-20 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multiplanar handling >

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-09-09 Thread Hans Verkuil
Hi Helen, Again I'm just reviewing the uAPI. On 04/08/2020 21:29, Helen Koike wrote: > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multipl

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-08-14 Thread Alexandre Courbot
On Wed, Aug 5, 2020 at 4:32 AM Helen Koike wrote: > > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multiplanar handling > 3/ Add a new start

[PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-08-04 Thread Helen Koike
From: Hans Verkuil Those extended buffer ops have several purpose: 1/ Fix y2038 issues by converting the timestamp into an u64 counting the number of ns elapsed since 1970 2/ Unify single/multiplanar handling 3/ Add a new start offset field to each v4l2 plane buffer info struct to support t