Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-04-06 Thread Uwe Kleine-König
Hello Thierry, On Tue, Apr 06, 2021 at 03:47:15PM +0200, Thierry Reding wrote: > On Tue, Apr 06, 2021 at 08:33:57AM +0200, Uwe Kleine-König wrote: > > On Wed, Mar 31, 2021 at 05:52:45PM +0200, Thierry Reding wrote: > > > On Wed, Mar 31, 2021 at 12:25:43PM +0200, Uwe Kleine-König wrote: > > > > On

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-04-06 Thread Thierry Reding
On Tue, Apr 06, 2021 at 08:33:57AM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Wed, Mar 31, 2021 at 05:52:45PM +0200, Thierry Reding wrote: > > On Wed, Mar 31, 2021 at 12:25:43PM +0200, Uwe Kleine-König wrote: > > > On Mon, Mar 22, 2021 at 09:34:21AM +0100, Thierry Reding wrote: > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-04-06 Thread Uwe Kleine-König
Hello Thierry, On Wed, Mar 31, 2021 at 05:52:45PM +0200, Thierry Reding wrote: > On Wed, Mar 31, 2021 at 12:25:43PM +0200, Uwe Kleine-König wrote: > > On Mon, Mar 22, 2021 at 09:34:21AM +0100, Thierry Reding wrote: > > > On Mon, Jan 11, 2021 at 09:43:50PM +0100, Uwe Kleine-König wrote: > > > > On

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-31 Thread Thierry Reding
On Wed, Mar 31, 2021 at 12:25:43PM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Mon, Mar 22, 2021 at 09:34:21AM +0100, Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 09:43:50PM +0100, Uwe Kleine-König wrote: > > > On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-31 Thread Uwe Kleine-König
Hello Thierry, On Mon, Mar 22, 2021 at 09:34:21AM +0100, Thierry Reding wrote: > On Mon, Jan 11, 2021 at 09:43:50PM +0100, Uwe Kleine-König wrote: > > On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > > > Another point is the period: Sven suggested we do not read out the > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-27 Thread Clemens Gruber
Hi Thierry, On Mon, Mar 22, 2021 at 10:19:22AM +0100, Thierry Reding wrote: > On Fri, Jan 29, 2021 at 09:37:47PM +0100, Clemens Gruber wrote: > > Hi Sven, > > > > On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > > > Hi Clemens, > > > > > > On Fri, Jan 29, 2021 at 11:31 AM

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Uwe Kleine-König
Hello, On Mon, Mar 22, 2021 at 02:15:08PM +0200, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 1:48 PM Uwe Kleine-König > wrote: > > On Mon, Mar 22, 2021 at 01:40:57PM +0200, Andy Shevchenko wrote: > > > On Mon, Mar 22, 2021 at 1:22 PM Uwe Kleine-König > > > wrote: > > > > When the PWM

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 1:48 PM Uwe Kleine-König wrote: > On Mon, Mar 22, 2021 at 01:40:57PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 22, 2021 at 1:22 PM Uwe Kleine-König > > wrote: > > > On Mon, Mar 22, 2021 at 11:38:40AM +0200, Andy Shevchenko wrote: > > > > On Monday, March 22, 2021,

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Uwe Kleine-König
On Mon, Mar 22, 2021 at 01:40:57PM +0200, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 1:22 PM Uwe Kleine-König > wrote: > > On Mon, Mar 22, 2021 at 11:38:40AM +0200, Andy Shevchenko wrote: > > > On Monday, March 22, 2021, Thierry Reding > > > wrote: > > > > On Fri, Jan 29, 2021 at

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 1:22 PM Uwe Kleine-König wrote: > On Mon, Mar 22, 2021 at 11:38:40AM +0200, Andy Shevchenko wrote: > > On Monday, March 22, 2021, Thierry Reding wrote: > > > On Fri, Jan 29, 2021 at 09:37:47PM +0100, Clemens Gruber wrote: > > > > Thierry: Would you accept it if we

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Uwe Kleine-König
Hello Andy, On Mon, Mar 22, 2021 at 11:38:40AM +0200, Andy Shevchenko wrote: > On Monday, March 22, 2021, Thierry Reding wrote: > > On Fri, Jan 29, 2021 at 09:37:47PM +0100, Clemens Gruber wrote: > > > Thierry: Would you accept it if we continue to reset the registers in > > > .probe? > > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Fri, Jan 29, 2021 at 09:37:47PM +0100, Clemens Gruber wrote: > Hi Sven, > > On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > > Hi Clemens, > > > > On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber > > wrote: > > > > > > Ok, so you suggest we extend our get_state logic to

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > Hi Clemens, > > On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber > wrote: > > > > Ok, so you suggest we extend our get_state logic to deal with cases > > like the following: > > Kind of. We can't control how other actors

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Thu, Jan 14, 2021 at 06:16:22PM +0100, Clemens Gruber wrote: > Hi, > > On Mon, Jan 11, 2021 at 09:35:32PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Thu, Dec 17, 2020 at 06:43:04PM +0100, Clemens Gruber wrote: > > > On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote:

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Mon, Jan 11, 2021 at 09:35:32PM +0100, Uwe Kleine-König wrote: > Hello, > > On Thu, Dec 17, 2020 at 06:43:04PM +0100, Clemens Gruber wrote: > > On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote: > > > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > > > wrote: > > > > > > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Mon, Jan 11, 2021 at 09:43:50PM +0100, Uwe Kleine-König wrote: > On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > > Another point is the period: Sven suggested we do not read out the > > period at all, as the PWM is disabled anyway (see above). > > Is this acceptable? > > In

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > Hi everyone, > > happy new year, hope you are all well! > > On Thu, Dec 17, 2020 at 12:52:42PM -0500, Sven Van Asbroeck wrote: > > On Thu, Dec 17, 2020 at 12:43 PM Clemens Gruber > > wrote: > > > > > > > > Conclusion:

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-04 Thread Clemens Gruber
Hi Uwe, On Mon, Mar 01, 2021 at 10:52:48PM +0100, Uwe Kleine-König wrote: > Hello, > > On Mon, Feb 01, 2021 at 06:24:02PM +0100, Clemens Gruber wrote: > > Hi Sven, Thierry, Uwe, > > > > On Fri, Jan 29, 2021 at 05:16:51PM -0500, Sven Van Asbroeck wrote: > > > Hi Clemens, > > > > > > On Fri, Jan

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-01 Thread Uwe Kleine-König
Hello, On Mon, Feb 01, 2021 at 06:24:02PM +0100, Clemens Gruber wrote: > Hi Sven, Thierry, Uwe, > > On Fri, Jan 29, 2021 at 05:16:51PM -0500, Sven Van Asbroeck wrote: > > Hi Clemens, > > > > On Fri, Jan 29, 2021 at 4:24 PM Sven Van Asbroeck > > wrote: > > > > > > LEN_ON = 409, LED_OFF = 1228

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-02-14 Thread Clemens Gruber
Hi all, On Fri, Jan 29, 2021 at 09:37:47PM +0100, Clemens Gruber wrote: > Hi Sven, > > On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > > Hi Clemens, > > > > On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber > > wrote: > > > > > > Ok, so you suggest we extend our get_state

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-02-01 Thread Clemens Gruber
Hi Sven, Thierry, Uwe, On Fri, Jan 29, 2021 at 05:16:51PM -0500, Sven Van Asbroeck wrote: > Hi Clemens, > > On Fri, Jan 29, 2021 at 4:24 PM Sven Van Asbroeck wrote: > > > > LEN_ON = 409, LED_OFF = 1228 and > > LED_ON = 419, LED_OFF = 1238 > > produce the same result. you can't see the

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Sven Van Asbroeck
Hi Clemens, On Fri, Jan 29, 2021 at 4:24 PM Sven Van Asbroeck wrote: > > LEN_ON = 409, LED_OFF = 1228 and > LED_ON = 419, LED_OFF = 1238 > produce the same result. you can't see the difference between the two > when scoping the channel. there are probably more ways to do this, > some might

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Sven Van Asbroeck
Hi Clemens, On Fri, Jan 29, 2021 at 3:37 PM Clemens Gruber wrote: > > Is the driver really responsible for bootloaders that program the chip > with invalid values? No, but it's responsible for correcting invalid values. Otherwise the driver doesn't work. > The chip comes out of PoR with sane

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Clemens Gruber
Hi Sven, On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > Hi Clemens, > > On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber > wrote: > > > > Ok, so you suggest we extend our get_state logic to deal with cases > > like the following: > > Kind of. We can't control how other

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Sven Van Asbroeck
Hi Clemens, On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber wrote: > > Ok, so you suggest we extend our get_state logic to deal with cases > like the following: Kind of. We can't control how other actors (bootloaders etc) program the chip. As far as I know, there are many, many different

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Clemens Gruber
Hi Sven, On Fri, Jan 29, 2021 at 08:42:13AM -0500, Sven Van Asbroeck wrote: > On Mon, Jan 11, 2021 at 3:35 PM Uwe Kleine-König > wrote: > > > > My position here is: A consumer should disable a PWM before calling > > pwm_put. The driver should however not enforce this and so should not > > modify

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-14 Thread Uwe Kleine-König
Hello Clemens, On Thu, Jan 14, 2021 at 06:16:22PM +0100, Clemens Gruber wrote: > On Mon, Jan 11, 2021 at 09:35:32PM +0100, Uwe Kleine-König wrote: > > My position here is: A consumer should disable a PWM before calling > > pwm_put. The driver should however not enforce this and so should not > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-14 Thread Clemens Gruber
Hi, On Mon, Jan 11, 2021 at 09:35:32PM +0100, Uwe Kleine-König wrote: > Hello, > > On Thu, Dec 17, 2020 at 06:43:04PM +0100, Clemens Gruber wrote: > > On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote: > > > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > > > wrote: > > > > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-11 Thread Uwe Kleine-König
On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > Another point is the period: Sven suggested we do not read out the > period at all, as the PWM is disabled anyway (see above). > Is this acceptable? In my eyes consumers should consider the period value as "don't care" if the PWM

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-11 Thread Uwe Kleine-König
Hello, On Thu, Dec 17, 2020 at 06:43:04PM +0100, Clemens Gruber wrote: > On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote: > > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > > wrote: > > > > > > Implements .get_state to read-out the current hardware state. > > > > > > > I am

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-07 Thread Sven Van Asbroeck
On Sun, Jan 3, 2021 at 12:04 PM Clemens Gruber wrote: > > I will continue working on this series in the upcoming weeks. > Feedback on the .get_state issue would be greatly appreciated. In absence of specifications, I tend to keep things as simple as possible.

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-03 Thread Clemens Gruber
Hi everyone, happy new year, hope you are all well! On Thu, Dec 17, 2020 at 12:52:42PM -0500, Sven Van Asbroeck wrote: > On Thu, Dec 17, 2020 at 12:43 PM Clemens Gruber > wrote: > > > > > > Conclusion: .get_state() will always return "pwm disabled", so why do we > > > bother reading out the

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2020-12-17 Thread Sven Van Asbroeck
On Thu, Dec 17, 2020 at 12:43 PM Clemens Gruber wrote: > > > > Conclusion: .get_state() will always return "pwm disabled", so why do we > > bother reading out the h/w? > > If there are no plans for the PWM core to call .get_state more often in > the future, we could just read out the period and

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2020-12-17 Thread Clemens Gruber
On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote: > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > wrote: > > > > Implements .get_state to read-out the current hardware state. > > > > I am not convinced that we actually need this. > > Looking at the pwm core, .get_state() is

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2020-12-16 Thread Sven Van Asbroeck
On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber wrote: > > Implements .get_state to read-out the current hardware state. > I am not convinced that we actually need this. Looking at the pwm core, .get_state() is only called right after .request(), to initialize the cached value of the state. The

[PATCH v5 2/7] pwm: pca9685: Support hardware readout

2020-12-15 Thread Clemens Gruber
Implements .get_state to read-out the current hardware state. The hardware readout may return slightly different values than those that were set in apply due to the limited range of possible prescale and counter register values. Also note that although the datasheet mentions 200 Hz as default