Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 05:08 PM, Paul Turner wrote: >> > >> > >> > Do you mean to move the rq->avg and task_group->load_avg into CONFIG_SMP? > More generally: Why do we need them in !CONFIG_SMP? > > [ I was suggesting (potentially) using only rq->avg in the !CONFIG_SMP case. ] > > Paul, here is the

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Preeti U Murthy
Hi Paul, On 05/06/2013 02:38 PM, Paul Turner wrote: > On Mon, May 6, 2013 at 1:57 AM, Alex Shi wrote: >> On 05/06/2013 04:01 PM, Paul Turner wrote: >>> On Sun, May 5, 2013 at 6:45 PM, Alex Shi wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 05:08 PM, Paul Turner wrote: > On Mon, May 6, 2013 at 1:57 AM, Alex Shi wrote: >> On 05/06/2013 04:01 PM, Paul Turner wrote: >>> On Sun, May 5, 2013 at 6:45 PM, Alex Shi wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Paul Turner
On Mon, May 6, 2013 at 1:57 AM, Alex Shi wrote: > On 05/06/2013 04:01 PM, Paul Turner wrote: >> On Sun, May 5, 2013 at 6:45 PM, Alex Shi wrote: >>> The following variables were covered under CONFIG_SMP in struct cfs_rq. >>> but similar runnable variables work for UP in struct rq and task_group.

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 04:01 PM, Paul Turner wrote: > On Sun, May 5, 2013 at 6:45 PM, Alex Shi wrote: >> The following variables were covered under CONFIG_SMP in struct cfs_rq. >> but similar runnable variables work for UP in struct rq and task_group. >> like rq->avg, task_group->load_avg. >> So move them

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Paul Turner
On Sun, May 5, 2013 at 6:45 PM, Alex Shi wrote: > The following variables were covered under CONFIG_SMP in struct cfs_rq. > but similar runnable variables work for UP in struct rq and task_group. > like rq->avg, task_group->load_avg. > So move them out, they also can work with UP. Is there a

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 12:11 PM, Preeti U Murthy wrote: > Hi Alex, > > You might want to do the below for struct sched_entity also? > AFAIK,struct sched_entity has struct sched_avg under CONFIG_SMP. > Ops, why it passed my UP config building? Anyway will check and test more. Thanks Preeti! -- Thanks

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Preeti U Murthy
Hi Alex, You might want to do the below for struct sched_entity also? AFAIK,struct sched_entity has struct sched_avg under CONFIG_SMP. Regards Preeti U Murthy On 05/06/2013 07:15 AM, Alex Shi wrote: > The following variables were covered under CONFIG_SMP in struct cfs_rq. > but similar runnable

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 05:08 PM, Paul Turner wrote: On Mon, May 6, 2013 at 1:57 AM, Alex Shi alex@intel.com wrote: On 05/06/2013 04:01 PM, Paul Turner wrote: On Sun, May 5, 2013 at 6:45 PM, Alex Shi alex@intel.com wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq.

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Preeti U Murthy
Hi Paul, On 05/06/2013 02:38 PM, Paul Turner wrote: On Mon, May 6, 2013 at 1:57 AM, Alex Shi alex@intel.com wrote: On 05/06/2013 04:01 PM, Paul Turner wrote: On Sun, May 5, 2013 at 6:45 PM, Alex Shi alex@intel.com wrote: The following variables were covered under CONFIG_SMP in struct

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 05:08 PM, Paul Turner wrote: Do you mean to move the rq-avg and task_group-load_avg into CONFIG_SMP? More generally: Why do we need them in !CONFIG_SMP? [ I was suggesting (potentially) using only rq-avg in the !CONFIG_SMP case. ] Paul, here is the patch according to

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Preeti U Murthy
Hi Alex, You might want to do the below for struct sched_entity also? AFAIK,struct sched_entity has struct sched_avg under CONFIG_SMP. Regards Preeti U Murthy On 05/06/2013 07:15 AM, Alex Shi wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 12:11 PM, Preeti U Murthy wrote: Hi Alex, You might want to do the below for struct sched_entity also? AFAIK,struct sched_entity has struct sched_avg under CONFIG_SMP. Ops, why it passed my UP config building? Anyway will check and test more. Thanks Preeti! -- Thanks

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Paul Turner
On Sun, May 5, 2013 at 6:45 PM, Alex Shi alex@intel.com wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable variables work for UP in struct rq and task_group. like rq-avg, task_group-load_avg. So move them out, they also can work with UP. Is

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Alex Shi
On 05/06/2013 04:01 PM, Paul Turner wrote: On Sun, May 5, 2013 at 6:45 PM, Alex Shi alex@intel.com wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable variables work for UP in struct rq and task_group. like rq-avg, task_group-load_avg. So

Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-06 Thread Paul Turner
On Mon, May 6, 2013 at 1:57 AM, Alex Shi alex@intel.com wrote: On 05/06/2013 04:01 PM, Paul Turner wrote: On Sun, May 5, 2013 at 6:45 PM, Alex Shi alex@intel.com wrote: The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable variables work for UP in

[PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-05 Thread Alex Shi
The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable variables work for UP in struct rq and task_group. like rq->avg, task_group->load_avg. So move them out, they also can work with UP. u64 runnable_load_avg, blocked_load_avg; atomic64_t

[PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq

2013-05-05 Thread Alex Shi
The following variables were covered under CONFIG_SMP in struct cfs_rq. but similar runnable variables work for UP in struct rq and task_group. like rq-avg, task_group-load_avg. So move them out, they also can work with UP. u64 runnable_load_avg, blocked_load_avg; atomic64_t