Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-27 Thread Lee Jones
On Mon, 26 Nov 2018, Pascal PAILLET-LME wrote: > Hi Lee, > I have just one question regarding i2c_device_id. Don't forget to trim your responses. Lots of unrequired quotes here. [...] > >> +static const struct i2c_device_id stpmic1_id[] = { > >> + { "stpmic1"}, > >> + {} > >> +}; > > I don't

Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-27 Thread Lee Jones
On Mon, 26 Nov 2018, Pascal PAILLET-LME wrote: > Hi Lee, > I have just one question regarding i2c_device_id. Don't forget to trim your responses. Lots of unrequired quotes here. [...] > >> +static const struct i2c_device_id stpmic1_id[] = { > >> + { "stpmic1"}, > >> + {} > >> +}; > > I don't

Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-26 Thread Pascal PAILLET-LME
Hi Lee, I have just one question regarding i2c_device_id. Le 11/13/2018 08:40 AM, Lee Jones a écrit : > On Mon, 29 Oct 2018, Pascal PAILLET-LME wrote: > >> stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 > "STPMIC1 is a PMIC" > >> regulators, 3 power switches, a watchdog and

Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-26 Thread Pascal PAILLET-LME
Hi Lee, I have just one question regarding i2c_device_id. Le 11/13/2018 08:40 AM, Lee Jones a écrit : > On Mon, 29 Oct 2018, Pascal PAILLET-LME wrote: > >> stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 > "STPMIC1 is a PMIC" > >> regulators, 3 power switches, a watchdog and

Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-12 Thread Lee Jones
On Mon, 29 Oct 2018, Pascal PAILLET-LME wrote: > stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 "STPMIC1 is a PMIC" > regulators, 3 power switches, a watchdog and an input for a power on key. > > Signed-off-by: Pascal Paillet > --- > changes in v5: > * use macro to

Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-12 Thread Lee Jones
On Mon, 29 Oct 2018, Pascal PAILLET-LME wrote: > stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 "STPMIC1 is a PMIC" > regulators, 3 power switches, a watchdog and an input for a power on key. > > Signed-off-by: Pascal Paillet > --- > changes in v5: > * use macro to

[PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-10-29 Thread Pascal PAILLET-LME
stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 regulators, 3 power switches, a watchdog and an input for a power on key. Signed-off-by: Pascal Paillet --- changes in v5: * use macro to define regmap register ranges * use REGMAP_IRQ_REG marco to define interrupts * remove st

[PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-10-29 Thread Pascal PAILLET-LME
stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 regulators, 3 power switches, a watchdog and an input for a power on key. Signed-off-by: Pascal Paillet --- changes in v5: * use macro to define regmap register ranges * use REGMAP_IRQ_REG marco to define interrupts * remove st