Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-06 Thread Jack Andersen
The restart command doesn't behave like other commands. It doesn't return an error code (which indicates a failed transfer in the dln2 module so the probe fails). Attached is a system log snippet to give you a better idea. I'm able to consistently reproduce this behavior on 4.12 by registering an

Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-06 Thread Jack Andersen
The restart command doesn't behave like other commands. It doesn't return an error code (which indicates a failed transfer in the dln2 module so the probe fails). Attached is a system log snippet to give you a better idea. I'm able to consistently reproduce this behavior on 4.12 by registering an

Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-06 Thread Lee Jones
On Wed, 05 Jul 2017, Jack Andersen wrote: > I have mixed feelings about making this patch. The device appears to > lose its ability to send command responses when the driver > unexpectedly goes offline (probably overflowing an internal send > buffer). > > The restart command is a send-only way

Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-06 Thread Lee Jones
On Wed, 05 Jul 2017, Jack Andersen wrote: > I have mixed feelings about making this patch. The device appears to > lose its ability to send command responses when the driver > unexpectedly goes offline (probably overflowing an internal send > buffer). > > The restart command is a send-only way

Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-05 Thread Jack Andersen
I have mixed feelings about making this patch. The device appears to lose its ability to send command responses when the driver unexpectedly goes offline (probably overflowing an internal send buffer). The restart command is a send-only way to recover the device. What concerns me is if there's

Re: [PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-05 Thread Jack Andersen
I have mixed feelings about making this patch. The device appears to lose its ability to send command responses when the driver unexpectedly goes offline (probably overflowing an internal send buffer). The restart command is a send-only way to recover the device. What concerns me is if there's

[PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-05 Thread Jack Andersen
There's an issue with reinitializing DLN2 hardware if ADC channel event configurations aren't reset before suspending the driver. A physical reconnect of the device solves the problem, but restarting the machine without a power cycle leaves the device state inconsistent. This patch transmits a

[PATCH v5 3/3] mfd: dln2: Send restart command if HW init fails

2017-07-05 Thread Jack Andersen
There's an issue with reinitializing DLN2 hardware if ADC channel event configurations aren't reset before suspending the driver. A physical reconnect of the device solves the problem, but restarting the machine without a power cycle leaves the device state inconsistent. This patch transmits a