Re: [PATCH v5 3/4] iio: hid-sensor-magn-3d: Scan for usage attributes before setting up iio channels

2014-07-09 Thread Reyad Attiyat
Hey Jonathan, I noticed this patch fails checkpatch script. I made small change and forgot to double check, sorry. It complains of assigment in if statement in capture_value: if (!!(iio_val = magn_state->magn_val_addr[offset])) I'll break this into two lines if your ok with this implementation

[PATCH v5 3/4] iio: hid-sensor-magn-3d: Scan for usage attributes before setting up iio channels

2014-07-09 Thread Reyad Attiyat
Scan for and count the HID usage attributes supported by the driver. This allows for the driver to only setup the IIO channels for the sensor usages present in the HID USB reports. Changes from v4 Renamed iio_val array to iio_vals Renamed return value of hid sensor attribute for loop Fixed

[PATCH v5 3/4] iio: hid-sensor-magn-3d: Scan for usage attributes before setting up iio channels

2014-07-09 Thread Reyad Attiyat
Scan for and count the HID usage attributes supported by the driver. This allows for the driver to only setup the IIO channels for the sensor usages present in the HID USB reports. Changes from v4 Renamed iio_val array to iio_vals Renamed return value of hid sensor attribute for loop Fixed

Re: [PATCH v5 3/4] iio: hid-sensor-magn-3d: Scan for usage attributes before setting up iio channels

2014-07-09 Thread Reyad Attiyat
Hey Jonathan, I noticed this patch fails checkpatch script. I made small change and forgot to double check, sorry. It complains of assigment in if statement in capture_value: if (!!(iio_val = magn_state-magn_val_addr[offset])) I'll break this into two lines if your ok with this implementation