Re: [PATCH v5 3/4] mm: introduce page memcg flags

2020-10-14 Thread Michal Hocko
On Fri 02-10-20 10:25:58, Roman Gushchin wrote: > The lowest bit in page->memcg_data is used to distinguish between > struct memory_cgroup pointer and a pointer to a objcgs array. > All checks and modifications of this bit are open-coded. > > Let's formalize it using page memcg flags, defined in e

Re: [PATCH v5 3/4] mm: introduce page memcg flags

2020-10-05 Thread Johannes Weiner
On Fri, Oct 02, 2020 at 10:25:58AM -0700, Roman Gushchin wrote: > The lowest bit in page->memcg_data is used to distinguish between > struct memory_cgroup pointer and a pointer to a objcgs array. > All checks and modifications of this bit are open-coded. > > Let's formalize it using page memcg fla

[PATCH v5 3/4] mm: introduce page memcg flags

2020-10-02 Thread Roman Gushchin
The lowest bit in page->memcg_data is used to distinguish between struct memory_cgroup pointer and a pointer to a objcgs array. All checks and modifications of this bit are open-coded. Let's formalize it using page memcg flags, defined in enum page_memcg_data_flags. Additional flags might be adde