Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

On Wed, Aug 23, 2017 at 08:59:00AM -0700, Andi Kleen wrote: > > so if I find HITM with this flag set I should count it > > as remote HITM then? something like attached.. untested > > You mean for c2c? Yes looks reasonable. yes, it seems to fix c2c to find remote HITMs again on skylake.. I'll

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

On Wed, Aug 23, 2017 at 08:59:00AM -0700, Andi Kleen wrote: > > so if I find HITM with this flag set I should count it > > as remote HITM then? something like attached.. untested > > You mean for c2c? Yes looks reasonable. yes, it seems to fix c2c to find remote HITMs again on skylake.. I'll

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

> so if I find HITM with this flag set I should count it > as remote HITM then? something like attached.. untested You mean for c2c? Yes looks reasonable. -Andi > > thanks, > jirka > > --- > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > index

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

> so if I find HITM with this flag set I should count it > as remote HITM then? something like attached.. untested You mean for c2c? Yes looks reasonable. -Andi > > thanks, > jirka > > --- > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > index

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

On Wed, Aug 23, 2017 at 07:00:32AM -0700, Andi Kleen wrote: > > Andi, > > how is this 'Remote' different from the remote levels in mem_lvl? > > > > "Remote RAM (1 hop)", > > "Remote RAM (2 hops)", > > "Remote Cache (1 hop)", > > "Remote Cache (2 hops)", > > It

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

On Wed, Aug 23, 2017 at 07:00:32AM -0700, Andi Kleen wrote: > > Andi, > > how is this 'Remote' different from the remote levels in mem_lvl? > > > > "Remote RAM (1 hop)", > > "Remote RAM (2 hops)", > > "Remote Cache (1 hop)", > > "Remote Cache (2 hops)", > > It

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

> Andi, > how is this 'Remote' different from the remote levels in mem_lvl? > > "Remote RAM (1 hop)", > "Remote RAM (2 hops)", > "Remote Cache (1 hop)", > "Remote Cache (2 hops)", It applies to any other level. This is needed to express "Remote unknown level", as

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

> Andi, > how is this 'Remote' different from the remote levels in mem_lvl? > > "Remote RAM (1 hop)", > "Remote RAM (2 hops)", > "Remote Cache (1 hop)", > "Remote Cache (2 hops)", It applies to any other level. This is needed to express "Remote unknown level", as

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

On Wed, Aug 16, 2017 at 03:21:55PM -0700, Andi Kleen wrote: SNIP > int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info) > { > size_t i, l = 0; > u64 m = PERF_MEM_LVL_NA; > u64 hit, miss; > + int printed; > > if (mem_info) > m

Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

On Wed, Aug 16, 2017 at 03:21:55PM -0700, Andi Kleen wrote: SNIP > int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info) > { > size_t i, l = 0; > u64 m = PERF_MEM_LVL_NA; > u64 hit, miss; > + int printed; > > if (mem_info) > m

[PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

From: Andi Kleen Add decoding for the new lvlx and snoopx field meminfo field added earlier to the kernel so that "perf mem report" and other tools can print it properly. v2: Merge with persistent memory patch. Switch to new bit encoding for each combination. v3: Switch to

[PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

From: Andi Kleen Add decoding for the new lvlx and snoopx field meminfo field added earlier to the kernel so that "perf mem report" and other tools can print it properly. v2: Merge with persistent memory patch. Switch to new bit encoding for each combination. v3: Switch to generic lvlnum field.