Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2021-01-22 Thread Corey Minyard
style point of view, but that's all I can tell. So I'm ok with it. Acked-by: Corey Minyard > > Thanks, > Chiawei > > > -Original Message- > > From: Andrew Jeffery > > Sent: Wednesday, January 20, 2021 1:03 PM > > Subject: Re: [PATCH v5 3/5

RE: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2021-01-22 Thread ChiaWei Wang
Hi Corey, Could you help to review this patch to kcs_bmc_aspeed.c? It mainly fixes the register layout/offsets of Aspeed LPC controller. Thanks, Chiawei > -Original Message- > From: Andrew Jeffery > Sent: Wednesday, January 20, 2021 1:03 PM > Subject: Re: [PATCH v5 3/

Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2021-01-19 Thread Andrew Jeffery
On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > Add check against LPC device v2 compatible string to > ensure that the fixed device tree layout is adopted. > The LPC register offsets are also fixed accordingly. > > Signed-off-by: Chia-Wei, Wang > Acked-by: Haiyue Wang Reviewed-by:

[PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2021-01-14 Thread Chia-Wei, Wang
Add check against LPC device v2 compatible string to ensure that the fixed device tree layout is adopted. The LPC register offsets are also fixed accordingly. Signed-off-by: Chia-Wei, Wang Acked-by: Haiyue Wang --- drivers/char/ipmi/kcs_bmc_aspeed.c | 27 --- 1 file