Re: [PATCH v5 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0

2016-10-05 Thread Tim Chen
On Wed, 2016-10-05 at 16:23 +0200, Thomas Gleixner wrote: > On Sat, 1 Oct 2016, Srinivas Pandruvada wrote: > > > > +void sched_set_itmt_support(bool itmt_supported) > > +{ > > + mutex_lock(_update_mutex); > > + > > + if (itmt_supported != sched_itmt_capable) > > + sched_itmt_capable

Re: [PATCH v5 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0

2016-10-05 Thread Tim Chen
On Wed, 2016-10-05 at 16:23 +0200, Thomas Gleixner wrote: > On Sat, 1 Oct 2016, Srinivas Pandruvada wrote: > > > > +void sched_set_itmt_support(bool itmt_supported) > > +{ > > + mutex_lock(_update_mutex); > > + > > + if (itmt_supported != sched_itmt_capable) > > + sched_itmt_capable

Re: [PATCH v5 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0

2016-10-05 Thread Thomas Gleixner
On Sat, 1 Oct 2016, Srinivas Pandruvada wrote: > +void sched_set_itmt_support(bool itmt_supported) > +{ > + mutex_lock(_update_mutex); > + > + if (itmt_supported != sched_itmt_capable) > + sched_itmt_capable = itmt_supported; Yikes. What is this conditional for? The only value

Re: [PATCH v5 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0

2016-10-05 Thread Thomas Gleixner
On Sat, 1 Oct 2016, Srinivas Pandruvada wrote: > +void sched_set_itmt_support(bool itmt_supported) > +{ > + mutex_lock(_update_mutex); > + > + if (itmt_supported != sched_itmt_capable) > + sched_itmt_capable = itmt_supported; Yikes. What is this conditional for? The only value

[PATCH v5 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0

2016-10-01 Thread Srinivas Pandruvada
From: Tim Chen On platforms supporting Intel Turbo Boost Max Technology 3.0, the maximum turbo frequencies of some cores in a CPU package may be higher than for the other cores in the same package. In that case, better performance (and possibly lower energy

[PATCH v5 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0

2016-10-01 Thread Srinivas Pandruvada
From: Tim Chen On platforms supporting Intel Turbo Boost Max Technology 3.0, the maximum turbo frequencies of some cores in a CPU package may be higher than for the other cores in the same package. In that case, better performance (and possibly lower energy consumption as well) can be achieved