Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 1:37 AM, Lyra Zhang wrote: > Hi, Rob > > I still have a question to be conform, specific describes below: > > On Mon, Jan 19, 2015 at 10:11 PM, Rob Herring wrote: >> On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang wrote: >>> On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Peter Hurley
On 01/20/2015 07:11 AM, Orson Zhai wrote: > Hi, Peter, > > Thank you for reviewing our code! > Some discussion below. > > On 2015年01月16日 23:20, Peter Hurley wrote: >> On 01/16/2015 05:00 AM, Chunyan Zhang wrote: >>> Add a full sc9836-uart driver for SC9836 SoC which is based on the >>>

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Orson Zhai
Hi, Peter, Thank you for reviewing our code! Some discussion below. On 2015年01月16日 23:20, Peter Hurley wrote: On 01/16/2015 05:00 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Orson Zhai
On Tue, Jan 20, 2015 at 3:37 PM, Lyra Zhang wrote: > Hi, Rob > > I still have a question to be conform, specific describes below: > > On Mon, Jan 19, 2015 at 10:11 PM, Rob Herring wrote: >> On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang wrote: >>> On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Orson Zhai
On Tue, Jan 20, 2015 at 3:37 PM, Lyra Zhang zhang.l...@gmail.com wrote: Hi, Rob I still have a question to be conform, specific describes below: On Mon, Jan 19, 2015 at 10:11 PM, Rob Herring robherri...@gmail.com wrote: On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang zhang.l...@gmail.com wrote:

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Orson Zhai
Hi, Peter, Thank you for reviewing our code! Some discussion below. On 2015年01月16日 23:20, Peter Hurley wrote: On 01/16/2015 05:00 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Peter Hurley
On 01/20/2015 07:11 AM, Orson Zhai wrote: Hi, Peter, Thank you for reviewing our code! Some discussion below. On 2015年01月16日 23:20, Peter Hurley wrote: On 01/16/2015 05:00 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 1:37 AM, Lyra Zhang zhang.l...@gmail.com wrote: Hi, Rob I still have a question to be conform, specific describes below: On Mon, Jan 19, 2015 at 10:11 PM, Rob Herring robherri...@gmail.com wrote: On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang zhang.l...@gmail.com wrote:

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-19 Thread Lyra Zhang
Hi, Rob I still have a question to be conform, specific describes below: On Mon, Jan 19, 2015 at 10:11 PM, Rob Herring wrote: > On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang wrote: >> On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring wrote: >>> On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang >>>

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-19 Thread Rob Herring
On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang wrote: > On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring wrote: >> On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang >> wrote: >>> Add a full sc9836-uart driver for SC9836 SoC which is based on the >>> spreadtrum sharkl64 platform. >>> This driver also

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-19 Thread Lyra Zhang
On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring wrote: > On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang > wrote: >> Add a full sc9836-uart driver for SC9836 SoC which is based on the >> spreadtrum sharkl64 platform. >> This driver also support earlycon. >> This patch also replaced the spaces

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-19 Thread Lyra Zhang
Hi, Rob I still have a question to be conform, specific describes below: On Mon, Jan 19, 2015 at 10:11 PM, Rob Herring robherri...@gmail.com wrote: On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang zhang.l...@gmail.com wrote: On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring robherri...@gmail.com wrote:

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-19 Thread Rob Herring
On Mon, Jan 19, 2015 at 3:55 AM, Lyra Zhang zhang.l...@gmail.com wrote: On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring robherri...@gmail.com wrote: On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang chunyan.zh...@spreadtrum.com wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-19 Thread Lyra Zhang
On Sat, Jan 17, 2015 at 12:41 AM, Rob Herring robherri...@gmail.com wrote: On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang chunyan.zh...@spreadtrum.com wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon.

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Rob Herring
On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang wrote: > Add a full sc9836-uart driver for SC9836 SoC which is based on the > spreadtrum sharkl64 platform. > This driver also support earlycon. > This patch also replaced the spaces between the macros and their > values with the tabs in

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Peter Hurley
On 01/16/2015 05:00 AM, Chunyan Zhang wrote: > Add a full sc9836-uart driver for SC9836 SoC which is based on the > spreadtrum sharkl64 platform. > This driver also support earlycon. > This patch also replaced the spaces between the macros and their > values with the tabs in serial_core.h The

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Baruch Siach
Hi Chunyan Zhang, On Fri, Jan 16, 2015 at 06:00:11PM +0800, Chunyan Zhang wrote: > + if (uart_handle_sysrq_char(port, ch)) > + continue; You don't define SUPPORT_SYSRQ, so uart_handle_sysrq_char has no effect. See include/linux/serial_core.h. baruch --

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Arnd Bergmann
On Friday 16 January 2015 18:00:11 Chunyan Zhang wrote: > Add a full sc9836-uart driver for SC9836 SoC which is based on the > spreadtrum sharkl64 platform. > This driver also support earlycon. > This patch also replaced the spaces between the macros and their > values with the tabs in

[PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Chunyan Zhang
Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This patch also replaced the spaces between the macros and their values with the tabs in serial_core.h Signed-off-by: Chunyan Zhang Signed-off-by: Orson Zhai

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Rob Herring
On Fri, Jan 16, 2015 at 4:00 AM, Chunyan Zhang chunyan.zh...@spreadtrum.com wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This patch also replaced the spaces between the macros and their values with

[PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Chunyan Zhang
Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This patch also replaced the spaces between the macros and their values with the tabs in serial_core.h Signed-off-by: Chunyan Zhang chunyan.zh...@spreadtrum.com

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Arnd Bergmann
On Friday 16 January 2015 18:00:11 Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This patch also replaced the spaces between the macros and their values with the tabs in serial_core.h

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Baruch Siach
Hi Chunyan Zhang, On Fri, Jan 16, 2015 at 06:00:11PM +0800, Chunyan Zhang wrote: + if (uart_handle_sysrq_char(port, ch)) + continue; You don't define SUPPORT_SYSRQ, so uart_handle_sysrq_char has no effect. See include/linux/serial_core.h. baruch --

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Peter Hurley
On 01/16/2015 05:00 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. This patch also replaced the spaces between the macros and their values with the tabs in serial_core.h The locking