Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-24 Thread Sam Ravnborg
Hi Sean/Hans. > > Hans de Goede sent out patches in September to convert it to a proper > > atomic driver. > > I recall that the feedback was mostly positive and that there was only > > minor things to left to do. Hans? I browsed the archieves and I could not find anything that was not addressed,

Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-24 Thread Sean Paul
On Thu, Jan 24, 2019 at 09:17:49PM +0100, Sam Ravnborg wrote: > Hi Sean. > > > > > > > Merge the previous 5 patches from this series, but this now goes boom on > > > vbox in staging. Needs another prep patch I think. > > > > Soo, can we drop vboxvideo yet? > > Hans de Goede sent out patches in

Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-24 Thread Sam Ravnborg
Hi Sean. > > > > Merge the previous 5 patches from this series, but this now goes boom on > > vbox in staging. Needs another prep patch I think. > > Soo, can we drop vboxvideo yet? Hans de Goede sent out patches in September to convert it to a proper atomic driver. I recall that the feedback wa

Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-24 Thread Sean Paul
On Thu, Jan 24, 2019 at 03:03:20PM +0100, Daniel Vetter wrote: > On Sat, Jan 19, 2019 at 09:40:14AM +0100, Sam Ravnborg wrote: > > With the removal of drmP.h from drm_modeset_helper.h > > the drmP.h are no longer included by any include files > > in include/drm. > > The drmP.h file is thus only inc

Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-24 Thread Sam Ravnborg
On Thu, Jan 24, 2019 at 03:03:20PM +0100, Daniel Vetter wrote: > On Sat, Jan 19, 2019 at 09:40:14AM +0100, Sam Ravnborg wrote: > > With the removal of drmP.h from drm_modeset_helper.h > > the drmP.h are no longer included by any include files > > in include/drm. > > The drmP.h file is thus only inc

Re: [PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-24 Thread Daniel Vetter
On Sat, Jan 19, 2019 at 09:40:14AM +0100, Sam Ravnborg wrote: > With the removal of drmP.h from drm_modeset_helper.h > the drmP.h are no longer included by any include files > in include/drm. > The drmP.h file is thus only included explicit > either in .c files or in local .h files. > This makes th

[PATCH v5 6/6] drm: remove drmP.h from drm_modeset_helper.h

2019-01-19 Thread Sam Ravnborg
With the removal of drmP.h from drm_modeset_helper.h the drmP.h are no longer included by any include files in include/drm. The drmP.h file is thus only included explicit either in .c files or in local .h files. This makes the process of deleting the drmP.h includes easier as we have a more local d