Re: [PATCH v5 6/7] blktrace: break out of blktrace setup on concurrent calls

2020-05-19 Thread Bart Van Assche
On 2020-05-15 20:19, Luis Chamberlain wrote: > [ ... ] Once Christoph's comments are addressed, feel free to add: Reviewed-by: Bart Van Assche

Re: [PATCH v5 6/7] blktrace: break out of blktrace setup on concurrent calls

2020-05-19 Thread Christoph Hellwig
On Sat, May 16, 2020 at 03:19:55AM +, Luis Chamberlain wrote: > We use one blktrace per request_queue, that means one per the entire > disk. So we cannot run one blktrace on say /dev/vda and then /dev/vda1, > or just two calls on /dev/vda. > > We check for concurrent setup only at the very

[PATCH v5 6/7] blktrace: break out of blktrace setup on concurrent calls

2020-05-15 Thread Luis Chamberlain
We use one blktrace per request_queue, that means one per the entire disk. So we cannot run one blktrace on say /dev/vda and then /dev/vda1, or just two calls on /dev/vda. We check for concurrent setup only at the very end of the blktrace setup though. If we try to run two concurrent blktraces