Re: [PATCH v5 7/9] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-11-15 Thread Borislav Petkov
On Tue, Nov 13, 2012 at 04:24:15PM -0600, Daniel Santos wrote: > Borislav, > > Please note that this patch has changed slightly since you Acked it. I > have moved the location of the negative-size array code to the end of > the macro. I don't think this really matters honestly, but I figured >

Re: [PATCH v5 7/9] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-11-15 Thread Borislav Petkov
On Tue, Nov 13, 2012 at 04:24:15PM -0600, Daniel Santos wrote: Borislav, Please note that this patch has changed slightly since you Acked it. I have moved the location of the negative-size array code to the end of the macro. I don't think this really matters honestly, but I figured this

Re: [PATCH v5 7/9] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-11-13 Thread Daniel Santos
Borislav, Please note that this patch has changed slightly since you Acked it. I have moved the location of the negative-size array code to the end of the macro. I don't think this really matters honestly, but I figured this was the best place to put that change. Daniel On 11/13/2012 04:13

[PATCH v5 7/9] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-11-13 Thread danielfsantos
Negative sized arrays wont create a compile-time error in some cases starting with gcc 4.4 (e.g., inlined functions), but gcc 4.3 introduced the error function attribute that will. This patch modifies BUILD_BUG_ON to behave like BUILD_BUG already does, using the error function attribute so that

[PATCH v5 7/9] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-11-13 Thread danielfsantos
Negative sized arrays wont create a compile-time error in some cases starting with gcc 4.4 (e.g., inlined functions), but gcc 4.3 introduced the error function attribute that will. This patch modifies BUILD_BUG_ON to behave like BUILD_BUG already does, using the error function attribute so that

Re: [PATCH v5 7/9] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-11-13 Thread Daniel Santos
Borislav, Please note that this patch has changed slightly since you Acked it. I have moved the location of the negative-size array code to the end of the macro. I don't think this really matters honestly, but I figured this was the best place to put that change. Daniel On 11/13/2012 04:13