Re: [PATCH v6] gpio: Add MOXA ART GPIO driver

2013-11-29 Thread Arnd Bergmann
On Friday 29 November 2013, Linus Walleij wrote: > On Thu, Nov 28, 2013 at 5:37 PM, Arnd Bergmann wrote: > > On Thursday 28 November 2013, Jonas Jensen wrote: > >> +static void __iomem *moxart_gpio_base; > > > > Just one comment: the usual way to do such a driver is to have > > a derived data stru

Re: [PATCH v6] gpio: Add MOXA ART GPIO driver

2013-11-29 Thread Linus Walleij
On Thu, Nov 28, 2013 at 5:37 PM, Arnd Bergmann wrote: > On Thursday 28 November 2013, Jonas Jensen wrote: >> +static void __iomem *moxart_gpio_base; > > Just one comment: the usual way to do such a driver is to have > a derived data structure like > > struct moxart_gpio_chip { > struct gpi

Re: [PATCH v6] gpio: Add MOXA ART GPIO driver

2013-11-28 Thread Arnd Bergmann
On Thursday 28 November 2013, Jonas Jensen wrote: > +static void __iomem *moxart_gpio_base; Just one comment: the usual way to do such a driver is to have a derived data structure like struct moxart_gpio_chip { struct gpio_chip chip; void __iomem *moxart_gpio_base; }; and dynamic

[PATCH v6] gpio: Add MOXA ART GPIO driver

2013-11-28 Thread Jonas Jensen
Add GPIO driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Thanks for reviewing! v5 writes to "pincontrol" are not needed, the pins work regardless. I took notes probing the pins with a multimeter, and I don't know the proper place for it, so I'm attachin