Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-09 Thread Brian Norris
On Fri, Aug 9, 2013 at 12:23 AM, Artem Bityutskiy wrote: > On Thu, 2013-08-08 at 23:00 -0700, Brian Norris wrote: >> On 08/08/2013 08:58 PM, Artem Bityutskiy wrote: >> > There are few minor issues in aiaiai, which I can fix if you hit them >> > and complain. Also, I did not invest much time in

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-09 Thread Artem Bityutskiy
On Thu, 2013-08-08 at 23:00 -0700, Brian Norris wrote: > On 08/08/2013 08:58 PM, Artem Bityutskiy wrote: > > On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote: > >> On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: > >>> Hi Artem & Brian: > Hi Huang and others, > >

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-09 Thread Brian Norris
On 08/08/2013 08:58 PM, Artem Bityutskiy wrote: On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote: On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: Hi Artem & Brian: Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijie wrote: 1.) Why add the ECC information

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-09 Thread Brian Norris
On 08/08/2013 08:58 PM, Artem Bityutskiy wrote: On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote: On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: Hi Artem Brian: Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijieb32...@freescale.com wrote: 1.) Why add

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-09 Thread Artem Bityutskiy
On Thu, 2013-08-08 at 23:00 -0700, Brian Norris wrote: On 08/08/2013 08:58 PM, Artem Bityutskiy wrote: On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote: On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: Hi Artem Brian: Hi Huang and others, On Thu, May 16, 2013 at

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-09 Thread Brian Norris
On Fri, Aug 9, 2013 at 12:23 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Thu, 2013-08-08 at 23:00 -0700, Brian Norris wrote: On 08/08/2013 08:58 PM, Artem Bityutskiy wrote: There are few minor issues in aiaiai, which I can fix if you hit them and complain. Also, I did not invest much

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-08 Thread Artem Bityutskiy
On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote: > On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: > > Hi Artem & Brian: > > >Hi Huang and others, > > > > > >On Thu, May 16, 2013 at 8:17 PM, Huang Shijie wrote: > > >>1.) Why add the ECC information to the nand_chip{} ? > ... >

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-08 Thread Brian Norris
On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: > Hi Artem & Brian: > >Hi Huang and others, > > > >On Thu, May 16, 2013 at 8:17 PM, Huang Shijie wrote: > >>1.) Why add the ECC information to the nand_chip{} ? ... > >Reviewed-by: Brian Norris > >Tested-by: Brian Norris > > > >Thanks

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-08 Thread Huang Shijie
Hi Artem & Brian: Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijie wrote: 1.) Why add the ECC information to the nand_chip{} ? Each nand chip has its requirement for the ECC correctability, such as "4bit ECC for each 512Byte" or "40bit ECC for each 1024Byte".

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-08 Thread Huang Shijie
Hi Artem Brian: Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijieb32...@freescale.com wrote: 1.) Why add the ECC information to the nand_chip{} ? Each nand chip has its requirement for the ECC correctability, such as 4bit ECC for each 512Byte or 40bit ECC for each

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-08 Thread Brian Norris
On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: Hi Artem Brian: Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijieb32...@freescale.com wrote: 1.) Why add the ECC information to the nand_chip{} ? ... Reviewed-by: Brian Norriscomputersforpe...@gmail.com

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-08-08 Thread Artem Bityutskiy
On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote: On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote: Hi Artem Brian: Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijieb32...@freescale.com wrote: 1.) Why add the ECC information to the nand_chip{} ? ...

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-07-04 Thread Huang Shijie
于 2013年05月16日 23:17, Huang Shijie 写道: > 1.) Why add the ECC information to the nand_chip{} ? >Each nand chip has its requirement for the ECC correctability, such as >"4bit ECC for each 512Byte" or "40bit ECC for each 1024Byte". >This ECC info is very important to the nand controller,

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-07-04 Thread Huang Shijie
于 2013年05月16日 23:17, Huang Shijie 写道: 1.) Why add the ECC information to the nand_chip{} ? Each nand chip has its requirement for the ECC correctability, such as 4bit ECC for each 512Byte or 40bit ECC for each 1024Byte. This ECC info is very important to the nand controller, such as

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-06-25 Thread Brian Norris
Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijie wrote: > 1.) Why add the ECC information to the nand_chip{} ? >Each nand chip has its requirement for the ECC correctability, such as >"4bit ECC for each 512Byte" or "40bit ECC for each 1024Byte". >This ECC info is

Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-06-25 Thread Brian Norris
Hi Huang and others, On Thu, May 16, 2013 at 8:17 PM, Huang Shijie b32...@freescale.com wrote: 1.) Why add the ECC information to the nand_chip{} ? Each nand chip has its requirement for the ECC correctability, such as 4bit ECC for each 512Byte or 40bit ECC for each 1024Byte. This

[PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-05-16 Thread Huang Shijie
1.) Why add the ECC information to the nand_chip{} ? Each nand chip has its requirement for the ECC correctability, such as "4bit ECC for each 512Byte" or "40bit ECC for each 1024Byte". This ECC info is very important to the nand controller, such as gpmi. Take the Micron

[PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}

2013-05-16 Thread Huang Shijie
1.) Why add the ECC information to the nand_chip{} ? Each nand chip has its requirement for the ECC correctability, such as 4bit ECC for each 512Byte or 40bit ECC for each 1024Byte. This ECC info is very important to the nand controller, such as gpmi. Take the Micron MT29F64G08CBABA