Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-15 Thread Thomas Gleixner
On Fri, 15 May 2015, Stefan Agner wrote: > On 2015-05-15 12:39, Thomas Gleixner wrote: > > On Sat, 9 May 2015, Stefan Agner wrote: > >> - irq_chip_unmask_parent(data); > >> + if (parent->chip->irq_enable) > >> + parent->chip->irq_enable(parent); > >> + else > >> +

Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-15 Thread Stefan Agner
On 2015-05-15 12:39, Thomas Gleixner wrote: > On Sat, 9 May 2015, Stefan Agner wrote: >> -irq_chip_unmask_parent(data); >> +if (parent->chip->irq_enable) >> +parent->chip->irq_enable(parent); >> +else >> +parent->chip->irq_unmask(parent); > > Why are you not

Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-15 Thread Thomas Gleixner
On Sat, 9 May 2015, Stefan Agner wrote: > - irq_chip_unmask_parent(data); > + if (parent->chip->irq_enable) > + parent->chip->irq_enable(parent); > + else > + parent->chip->irq_unmask(parent); Why are you not creating irq_chip_enable_parent() which would have

Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-15 Thread Thomas Gleixner
On Sat, 9 May 2015, Stefan Agner wrote: - irq_chip_unmask_parent(data); + if (parent-chip-irq_enable) + parent-chip-irq_enable(parent); + else + parent-chip-irq_unmask(parent); Why are you not creating irq_chip_enable_parent() which would have been the

Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-15 Thread Stefan Agner
On 2015-05-15 12:39, Thomas Gleixner wrote: On Sat, 9 May 2015, Stefan Agner wrote: -irq_chip_unmask_parent(data); +if (parent-chip-irq_enable) +parent-chip-irq_enable(parent); +else +parent-chip-irq_unmask(parent); Why are you not creating

Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-15 Thread Thomas Gleixner
On Fri, 15 May 2015, Stefan Agner wrote: On 2015-05-15 12:39, Thomas Gleixner wrote: On Sat, 9 May 2015, Stefan Agner wrote: - irq_chip_unmask_parent(data); + if (parent-chip-irq_enable) + parent-chip-irq_enable(parent); + else + parent-chip-irq_unmask(parent);

[PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-09 Thread Stefan Agner
Support the NVIC interrupt controller as node parent of the MSCM interrupt router. On the dual-core variants of Vybird (VF6xx), the NVIC interrupt controller is used by the Cortex-M4. To support running Linux on this core too, MSCM needs NVIC parent support too. Signed-off-by: Stefan Agner ---

[PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

2015-05-09 Thread Stefan Agner
Support the NVIC interrupt controller as node parent of the MSCM interrupt router. On the dual-core variants of Vybird (VF6xx), the NVIC interrupt controller is used by the Cortex-M4. To support running Linux on this core too, MSCM needs NVIC parent support too. Signed-off-by: Stefan Agner