Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-05 Thread Leo Yan
Hi Andre, Dave, On Mon, Nov 02, 2020 at 03:50:01PM +, André Przywara wrote: [...] > > int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, > > size_t buf_len) > > { > > - int ret, ns, el, idx = packet->index; > > + int ns, el, idx = packet->index; > >

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-04 Thread Leo Yan
On Tue, Nov 03, 2020 at 12:13:04PM +, Dave Martin wrote: > On Tue, Nov 03, 2020 at 10:13:49AM +, André Przywara wrote: > > On 03/11/2020 06:40, Leo Yan wrote: > > > > Hi Dave, Leo, > > > > > On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote: > > >> On Fri, Oct 30, 2020 at

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-03 Thread Dave Martin
On Tue, Nov 03, 2020 at 10:13:49AM +, André Przywara wrote: > On 03/11/2020 06:40, Leo Yan wrote: > > Hi Dave, Leo, > > > On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote: > >> On Fri, Oct 30, 2020 at 02:57:09AM +, Leo Yan wrote: > >>> When outputs strings to the decoding

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-03 Thread André Przywara
On 03/11/2020 06:40, Leo Yan wrote: Hi Dave, Leo, > On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote: >> On Fri, Oct 30, 2020 at 02:57:09AM +, Leo Yan wrote: >>> When outputs strings to the decoding buffer with function snprintf(), >>> SPE decoder needs to detects if any error

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-02 Thread Leo Yan
Hi Dave, On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote: > On Fri, Oct 30, 2020 at 02:57:09AM +, Leo Yan wrote: > > When outputs strings to the decoding buffer with function snprintf(), > > SPE decoder needs to detects if any error returns from snprintf() and if > > so needs to

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-02 Thread Leo Yan
On Mon, Nov 02, 2020 at 03:50:01PM +, André Przywara wrote: > On 30/10/2020 02:57, Leo Yan wrote: > > When outputs strings to the decoding buffer with function snprintf(), > > SPE decoder needs to detects if any error returns from snprintf() and if > > so needs to directly bail out. If

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-02 Thread Dave Martin
On Fri, Oct 30, 2020 at 02:57:09AM +, Leo Yan wrote: > When outputs strings to the decoding buffer with function snprintf(), > SPE decoder needs to detects if any error returns from snprintf() and if > so needs to directly bail out. If snprintf() returns success, it needs > to update buffer

Re: [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-11-02 Thread André Przywara
On 30/10/2020 02:57, Leo Yan wrote: > When outputs strings to the decoding buffer with function snprintf(), > SPE decoder needs to detects if any error returns from snprintf() and if > so needs to directly bail out. If snprintf() returns success, it needs > to update buffer pointer and reduce the

[PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer

2020-10-29 Thread Leo Yan
When outputs strings to the decoding buffer with function snprintf(), SPE decoder needs to detects if any error returns from snprintf() and if so needs to directly bail out. If snprintf() returns success, it needs to update buffer pointer and reduce the buffer length so can continue to output the