On Mon, 3 Aug 2020 13:22:38 -0400
Steven Rostedt wrote:
> On Mon, 3 Aug 2020 11:29:59 -0400
> Arvind Sankar wrote:
>
> > > + /* parse_args() stops at '--' and returns an address */
> > > + if (!IS_ERR(err) && err)
> > > + initargs_found = true;
> > > +
> >
> > I think you can drop
On Mon, 3 Aug 2020 11:29:59 -0400
Arvind Sankar wrote:
> > + /* parse_args() stops at '--' and returns an address */
> > + if (!IS_ERR(err) && err)
> > + initargs_found = true;
> > +
>
> I think you can drop the second IS_ERR, since we already checked that.
Masami,
Can you
On Tue, Aug 04, 2020 at 12:03:45AM +0900, Masami Hiramatsu wrote:
> On Sat, 1 Aug 2020 22:33:18 -0400
> Arvind Sankar wrote:
> >
> > I came across this as I was poking around some of the command line
> > parsing. AFAICT, initargs_found will never be set to true here, because
> > parse_args
On Sat, 1 Aug 2020 22:33:18 -0400
Arvind Sankar wrote:
> On Fri, Feb 07, 2020 at 02:46:03PM -0500, Steven Rostedt wrote:
> >
> > diff --git a/init/main.c b/init/main.c
> > index 491f1cdb3105..113c8244e5f0 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -142,6 +142,15 @@ static char
On Fri, Feb 07, 2020 at 02:46:03PM -0500, Steven Rostedt wrote:
>
> diff --git a/init/main.c b/init/main.c
> index 491f1cdb3105..113c8244e5f0 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -142,6 +142,15 @@ static char *extra_command_line;
> /* Extra init arguments */
> static char
5 matches
Mail list logo
