Re: [PATCH v6 09/40] xattr: handle idmapped mounts

2021-03-03 Thread Christian Brauner
On Wed, Mar 03, 2021 at 02:45:07PM +, David Howells wrote: > Christian Brauner wrote: > > > In order to answer this more confidently I need to know a bit more about > > how cachefiles are supposed to work. > > > > From what I gather here it seemed what this code is trying to set here > > is

Re: [PATCH v6 09/40] xattr: handle idmapped mounts

2021-03-03 Thread Christian Brauner
On Wed, Mar 03, 2021 at 01:24:02PM +, David Howells wrote: > Christian Brauner wrote: > > > diff --git a/fs/cachefiles/xattr.c b/fs/cachefiles/xattr.c > > index 72e42438f3d7..a591b5e09637 100644 > > --- a/fs/cachefiles/xattr.c > > +++ b/fs/cachefiles/xattr.c > > @@ -39,8 +39,8 @@ int

Re: [PATCH v6 09/40] xattr: handle idmapped mounts

2021-03-03 Thread David Howells
Christian Brauner wrote: > In order to answer this more confidently I need to know a bit more about > how cachefiles are supposed to work. > > From what I gather here it seemed what this code is trying to set here > is an internal "CacheFiles.cache" extended attribute on the indode. This >

Re: [PATCH v6 09/40] xattr: handle idmapped mounts

2021-03-03 Thread David Howells
Christian Brauner wrote: > diff --git a/fs/cachefiles/xattr.c b/fs/cachefiles/xattr.c > index 72e42438f3d7..a591b5e09637 100644 > --- a/fs/cachefiles/xattr.c > +++ b/fs/cachefiles/xattr.c > @@ -39,8 +39,8 @@ int cachefiles_check_object_type(struct cachefiles_object > *object) >