Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-10 Thread Mel Gorman
On Thu, Aug 09, 2012 at 12:12:19PM -0300, Rafael Aquini wrote: > On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote: > > Sure! > > what do you think of: > > > > +/* putback_lru_page() counterpart for a ballooned page */ > > +void putback_balloon_page(struct page *page) > > +{ > > +

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-10 Thread Mel Gorman
On Thu, Aug 09, 2012 at 12:12:19PM -0300, Rafael Aquini wrote: On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote: Sure! what do you think of: +/* putback_lru_page() counterpart for a ballooned page */ +void putback_balloon_page(struct page *page) +{ +

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Rafael Aquini
On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote: > Sure! > what do you think of: > > +/* putback_lru_page() counterpart for a ballooned page */ > +void putback_balloon_page(struct page *page) > +{ > + lock_page(page); > + if (!WARN_ON(!movable_balloon_page(page))) { > +

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Rafael Aquini
On Thu, Aug 09, 2012 at 10:00:19AM +0100, Mel Gorman wrote: > On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote: > > Memory fragmentation introduced by ballooning might reduce significantly > > the number of 2MB contiguous memory blocks that can be used within a guest, > > thus

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Mel Gorman
On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of >

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Mel Gorman
On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Rafael Aquini
On Thu, Aug 09, 2012 at 10:00:19AM +0100, Mel Gorman wrote: On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Rafael Aquini
On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote: Sure! what do you think of: +/* putback_lru_page() counterpart for a ballooned page */ +void putback_balloon_page(struct page *page) +{ + lock_page(page); + if (!WARN_ON(!movable_balloon_page(page))) { +

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Minchan Kim
Hi Rafael, On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Rik van Riel
On 08/08/2012 06:53 PM, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that

[PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

[PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Rik van Riel
On 08/08/2012 06:53 PM, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-08 Thread Minchan Kim
Hi Rafael, On Wed, Aug 08, 2012 at 07:53:19PM -0300, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number